Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tl] Update tl::expected and tl::optional, add tl::function_ref #7028

Merged
merged 6 commits into from
Jun 26, 2019
Merged

[tl] Update tl::expected and tl::optional, add tl::function_ref #7028

merged 6 commits into from
Jun 26, 2019

Conversation

TartanLlama
Copy link
Member

No description provided.

@ras0219-msft ras0219-msft merged commit 7b540fe into microsoft:master Jun 26, 2019
@ras0219-msft
Copy link
Contributor

Thanks for the update!

We want every build to be super reliable, so we don't like functions like FetchContent which can do crazy things at build time. I instead pre-fetch tl-cmake using our conventional helpers (vcpkg_from_github()) at a known version and pass that in to cmake's build.

pull bot pushed a commit to harrysummer/vcpkg that referenced this pull request Jun 26, 2019
@TartanLlama @pull
[tl] Update tl::expected and tl::optional, add tl::function_ref (micr…
10abe37 
…osoft#7028)

* [tl] Update tl::expected and tl::optional, add tl::function_ref

* [tl-expected][tl-function-ref][tl-optional] Always prepopulate FetchContent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TartanLlama @ras0219-msft