Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression on the fix for #50 #321

Closed
ovatsus opened this issue Mar 22, 2015 · 6 comments
Closed

Regression on the fix for #50 #321

ovatsus opened this issue Mar 22, 2015 · 6 comments
Labels

Comments

@ovatsus
Copy link

ovatsus commented Mar 22, 2015

I'm still seeing the _Print member. Either I dind't test it properly last time or the behavior has regressed

Repro:

Go to XmlProvider.fsx in F# Data (https://github.com/fsharp/FSharp.Data/blob/master/docs/content/library/XmlProvider.fsx#L276)

and add the type t = OutputXml.OrderLine line:

image

@ovatsus
Copy link
Author

ovatsus commented Mar 22, 2015

#50
/cc @forki

@latkin
Copy link
Contributor

latkin commented Mar 23, 2015

It seems to only still be a problem in provided types. And FWIW the member is not present in intellisense, only the tooltip.

This seems like a weird scenario - is the provided type inheriting from a record type?

@ovatsus
Copy link
Author

ovatsus commented Mar 23, 2015

Yes, the provided type inherits from a record type: https://github.com/fsharp/FSharp.Data/blob/master/src/Xml/XmlRuntime.fs#L61

The original bug was never about IntelliSense, was always about the tooltip

@latkin
Copy link
Contributor

latkin commented Mar 23, 2015

Is the _Print guy also implemented directly by the provided type, or does it only come along as part of the base type? From quick tests it doesn't look like base class members are normally shown at all in the tooltip for sub types.

Record types are supposed to be sealed I thought, I'm surprised you are permitted to inherit from them. Maybe this is a bug that it's allowed at all?

@ovatsus
Copy link
Author

ovatsus commented Mar 23, 2015

It only comes from base type. This is not real inheritance, though, it's the base type for an erased type.

@latkin
Copy link
Contributor

latkin commented Mar 23, 2015

I see the issue, provided types are routed to a different function that was not updated with the original fix. I'm testing a fix now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants