Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VS 15.6 RTW] alt-up/down arrows do not reposition file for legacy projects #4405

Closed
vsfeedback opened this issue Feb 28, 2018 · 4 comments
Closed
Labels
Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. Regression
Milestone

Comments

@vsfeedback
Copy link

vsfeedback commented Feb 28, 2018

VS 15.6 preview6

  1. Create a .NET Framework-based F# project
  2. Alt+up/Alt+Down on a file (Program.fs)

Expected: files move up/down
Actual: They don't

This issue has been moved from https://developercommunity.visualstudio.com/content/problem/204016/vs-156-preview6-alt-updown-arrows-do-not-repositio.html
VSTS ticketId: 572477

These are the original issue comments:
(no comments)
These are the original issue solutions:
(no solutions)

@cartermp cartermp changed the title VS 15.6 preview6, alt-up/down arrows do not reposition file VS 15.6 preview6, alt-up/down arrows do not reposition file for legacy projects Feb 28, 2018
@cartermp cartermp added the Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. label Feb 28, 2018
@cartermp
Copy link
Contributor

It's unclear if this is something we can adjust here, in dotnet-project-system, or in the VS editor itself. Either way, the root of the issue is that we assigned hotkeys to .NET Core SDK-based projects for Alt+Up/Alt+Down. This apparently removed the cability from legacy projects because you can only have one key binding per editor context.

@TIHan
Copy link
Member

TIHan commented Feb 28, 2018

We have a possible solution to this.

We need to create an interface that we export an implementation to execute the legacy VisualFSharp commands for MoveUp/Down. This interface will live in VisualFSharp.

Using COM definitions, we can have the same interface in dotnet/project-system and get an instance through MEF. With this instance, we can execute the legacy MoveUp/Down once we see a hierarchy that is not CPS based.

@cartermp
Copy link
Contributor

cartermp commented Feb 28, 2018

Labeling and adding to the 15.6 milestone. This won't block the release since we're so soon to shipping, but we're going to target a servicing release.

@cartermp cartermp changed the title VS 15.6 preview6, alt-up/down arrows do not reposition file for legacy projects [VS 15.6 RTW] alt-up/down arrows do not reposition file for legacy projects Mar 5, 2018
@cartermp
Copy link
Contributor

cartermp commented Mar 9, 2018

This has been fixed in dotnet/project-system#3331 and merged into a validation build. Servicing fix should be out fairly soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. Regression
Projects
None yet
Development

No branches or pull requests

3 participants