Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a F# .net core/standard project, the dependencies nodes occurs warning signs due to nuget package "System.ValueTupe". #4412

Closed
ghost opened this issue Mar 1, 2018 · 13 comments
Labels
Area-LangService-API Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Milestone

Comments

@ghost
Copy link

ghost commented Mar 1, 2018

Repro steps

Create a F# .net core/standard project, restore finished without any errors and warnings, but the dependencies nodes occurs warning signs due to nuget package System.ValueTupe(4.3.1).
Build and run the project succeeded.
image

Related information

VS build: d15.7stg/27428.3003 (15.7 Preview 1)
dotnet --info:

.NET Command Line Tools (2.1.100)

Product Information:
 Version:            2.1.100
 Commit SHA-1 hash:  b9e74c6520

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.10240
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.1.100\

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.5
  Build    : 17373eb129b3b05aa18ece963f8795d65ef8ea54


@ghost ghost changed the title Create a F# .net core/standard project, the dependencies nodes occurs warning signs due to due to nuget package "System.ValueTupe". Create a F# .net core/standard project, the dependencies nodes occurs warning signs due to nuget package "System.ValueTupe". Mar 1, 2018
@ghost
Copy link
Author

ghost commented Mar 9, 2018

Not repro on latest d15.7/27508.00.
But repro on latest d15.7stg/27508.3006.

@ghost
Copy link
Author

ghost commented Mar 13, 2018

Repro on latest d15.7/27512.00.

@cartermp
Copy link
Contributor

@KevinRansom you and I talked about this in the hall and you said you know why this is reproducing. I don't quite recall the reason why...

@cartermp cartermp added the Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. label Mar 13, 2018
@cartermp cartermp added this to the 15.7 milestone Mar 13, 2018
@cartermp
Copy link
Contributor

cartermp commented May 8, 2018

For posterity: @KevinRansom looked into this and it's awfully tricky with no quick fix. I don't recall the proposed solution. @KevinRansom?

@KevinRansom
Copy link
Member

Yes, it is awful. I think I had a fix in mind, but then get randomized ... It will take a while to get back to it, I need to focus on F# 4.5 for a while. I will try to get a fix in for Dev 15.8. No promises though.

@baltie
Copy link

baltie commented May 9, 2018

It might seem benign, and it is in many ways I guess, but it makes VS show yellow triangles on dependencies in all projects that reference an F# project right now. Which makes the yellow triangle pretty useless for tracking down actual dependency issues. I really hope you can get this fixed before 15.8, which is probably months away.

@karataliu
Copy link

Also saw this issue. Please help address it.

VS 15.7.2
F# Tools 10.1 for F# 4.1

@cartermp
Copy link
Contributor

This should now be fixed with #4990

@KevinRansom is this pending a CLI insertion to light in the tools?

@YunWeiaa
Copy link

Repro on d15.7/27703.2031.

@cartermp
Copy link
Contributor

@YunWeiaa I would expect this to continue to reproduce with 15.7 builds, as I don't think we've serviced the fix. It should no longer repro on d15.8 builds, though.

@YunWeiaa
Copy link

Got it. Thanks.

@BenjaminHolland
Copy link

Is there a fix for this, or do we just have to wait for a VS update?

@KevinRansom
Copy link
Member

@BenjaminHolland , it's fixed in VS2017.8 preview 3. We will not be patching vs2017.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-LangService-API Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Projects
None yet
Development

No branches or pull requests

6 participants