Any bug in QueueList?

[zhuangzhuang]

https://github.com/Microsoft/visualfsharp/blob/5daaf8294ab0adcf1a19a77935966e5b3a30c32e/src/fsharp/QueueList.fs#L37

member x.Append(ys:seq<_>) = QueueList(firstElements, (List.rev (Seq.toList ys) @ lastElementsRev), numLastElements+Seq.length ys))

counterexamples:

let headQueue = ofSeq [1..5]
let tailQueue = ofSeq [1..100000]
let temp = append headQueue tailQueue
temp.ToList() |>ignore // call List.rev inside
temp.ToList() |> ignore // call List.rev again

[zhuangzhuang]

miss understand, this is not a bug.
please close this issues.
sorry

[abelbraaksma]

@zhuangzhuang you can close your own bug by clicking the close button ;)

[zaaack]

@zhuangzhuang As we discussed yesterday, this is actually a bug here, could you please reopen it?

[forki]

@zaaack & @zhuangzhuang how did you spot this? Is there observable behaviour?

Anyway: fix is in #4727

[zaaack]

@forki Not me, it's @zhuangzhuang find this, I guess he found it by accident when reading vf's source code?

[forki]

mhm looks like I fixed another issue. It still does 2 reverse operations.

[forki]

@KevinRansom please reopen. The double reverse issue is not fixed.

[dsyme]

@forki Closing as this is internal to the compiler and would need an observable external behaviour in order to fix