Warn/Error when a Custom Attribute does not derive from Attribute #5610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Sep 8, 2018
KevinRansom
commented
Sep 8, 2018
src/fsharp/FSComp.txt
Outdated
| @@ -1435,8 +1435,9 @@ notAFunctionButMaybeDeclaration,"This value is not a function and cannot be appl | |||
| 3230,chkNoWriteToLimitedSpan,"This value can't be assigned because the target '%s' may refer to non-stack-local memory, while the expression being assigned is assessed to potentially refer to stack-local memory. This is to help prevent pointers to stack-bound memory escaping their scope." | |||
| 3231,tastValueMustBeLocal,"A value defined in a module must be mutable in order to take its address, e.g. 'let mutable x = ...'" | |||
| 3232,tcIsReadOnlyNotStruct,"A type annotated with IsReadOnly must also be a struct. Consider adding the [<Struct>] attribute to the type." | |||
| 3233,chkStructsMayNotReturnAddressesOfContents,"Struct members cannot return the address of fields of the struct by reference" | |||
There was a problem hiding this comment.
Hmm, I think these numbers should be returned to their original value. I have no idea how this happened I guess it was some merge nonsense.
There was a problem hiding this comment.
Yes I should, otherwise this basically undoes this change: d97c797
KevinRansom
force-pushed
the
warnoncustomattribute
branch
4 times, most recently
from
c469583
to
71dbbc0
Compare
KevinRansom
force-pushed
the
warnoncustomattribute
branch
3 times, most recently
from
d158f07
to
ac2f972
Compare
KevinRansom
force-pushed
the
warnoncustomattribute
branch
from
ac2f972
to
9834713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vasily-kirichenko provide this PR: #5192
Which makes CustomAttributes which do not derive from System.Attribute an error.
Our requirements are:
Justification,
It's a breaking change and has been usable for ever on .NET Framework projects, it is however, bad practice and can cause common .Net attribute reflection idioms to not work correctly.
So on .NET framework, we want to issue a warning because the existing behavior is wrong, and developers have the opportunity to fix it.
On .NET Sdk projects, we feel that the projects were recent and still highly likely to be actively developed. This will require developers to correct the attribute definition and move on …
Kevin