Second half of fix for https://github.com/Microsoft/visualfsharp/issues/106 #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FSharp.Compiler.Service contained a more complete fix for #106, which relates to the memory leaks that can arise if type provider instance objects are kept live. Historically the memory leaks have happened if a type provider registers itself to listen to file system events (or other notifications), but for some reason doesn't disconnect those listeners when the type provider is disposed. This keeps the type provider instance alive - which is a bug in the type provider - but even worse it can keep '00s MB of data associated with the compiler state alive as well.
The missing part of the fix is to disconnect the "TypeProviderConfig" callback when the type providers are disposed, so that even if a type provider instance hangs on to a reference to the TypeProviderConfig, that doesn't cause the entire object graph for the compilation session to be retained in memory.
After type provider disposal, any TypeProviderConfig objects provided to the type provider will now raise ObjectDisposedException when the SystemRuntimeContainsType method is called.