[RFC FS-1004] FSharpResult type with a few tests #964

wallymathieu · 2016-02-12T20:53:25Z

This is the implementation of RFC FS-1004 Result type

msftclas · 2016-02-12T20:53:29Z

Hi @wallymathieu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

msftclas · 2016-02-12T20:57:39Z

@wallymathieu, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

enricosada · 2016-02-14T11:24:09Z

@wallymathieu can you add

[WIP] to title
"Discuss on [RFC FS-1004 Discussion] Result type fsharp/fslang-design#49" in the pr description

forki · 2016-02-14T11:26:09Z

src/fsharp/FSharp.Core/control.fs

@@ -601,7 +601,7 @@ namespace Microsoft.FSharp.Control
        let mutable defaultCancellationTokenSource = new CancellationTokenSource()

        [<NoEquality; NoComparison>]
-        type Result<'T>  =
+        type AsyncImplResult<'T>  =


Is this a public type?

This is a private type. It's not exposed from control.fsi.

forki · 2016-02-14T11:29:53Z

How does this relate to Chessie? Are you going to port the tests over? If we really put this into FSharp.Core then it should at least do what Chessie can. Especially in regards to C# interop this is a really hard topic. I tried so many things to make Chessie work for C# - so please also port the C# samples / tests to show that we have at elast that basic C# support that Chessie has.

forki · 2016-02-14T11:35:31Z

/// <summary>Helper type for error handling without exceptions.</summary>
[<StructuralEquality; StructuralComparison>]
[<CompiledName("FSharpResult`2")>]
type Result<'T1,'T2> = 
| Success of 'T1 
| Error of 'T2

Is that really the type we want for Results? Chessie is using:

/// Represents the result of a computation.
type Result<'TSuccess, 'TMessage> = 
/// Represents the result of a successful computation.
| Ok of 'TSuccess * 'TMessage list
/// Represents the result of a failed computation.
| Bad of 'TMessage list

wallymathieu · 2016-02-14T12:40:49Z

@enricosada there, I've updated the description and title.

mexx · 2016-02-17T00:26:58Z

src/fsharp/FSharp.Core.Unittests/FSharp.Core/Microsoft.FSharp.Core/ResultTests.fs

+// Copyright (c) Microsoft Corporation.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
+
+// Various tests for:
+// Microsoft.FSharp.Core.ExtraTopLevelOperators.printf


Please adjust this comment to match the test target.

KevinRansom · 2016-06-25T10:05:22Z

@wallymathieu @forki @dsyme @otawfik-ms
Guys,
where are we on this PR? it hasn't been touched since mid-feb and so looks like it might be dead. Do we want to add this functionality, shall we find someone to shepherd it through or drop it?

Kevin

dsyme · 2016-06-25T14:14:44Z

src/fsharp/FSharp.Core/prim-types.fsi

+    [<StructuralEquality; StructuralComparison>]
+    [<CompiledName("FSharpResult`2")>]
+    type Result<'T1,'T2> = 
+      | Success of 'T1 


Please rename Success to Ok

Please rename the type variables to T and TError

dsyme · 2016-06-25T14:17:50Z

Please make the adjustments mentioned above and then we can accept this,

There is discussion in the RFC about whether we should also add a corresponding module of operations and a attempt builder into FSharp.Core as well. But minimally there is real value in accepting the definition of the type to help enable interop between different F# components that want to use this type.

wallymathieu · 2016-06-26T18:53:34Z

Should I do a merge from master and fix the compilation error in Commands.fs?

dsyme · 2016-06-28T13:59:11Z

@wallymathieu Yes please

wallymathieu · 2016-07-03T06:00:09Z

The failure of Windows_NT Release_ci_part2 Build :
FSharp.Core.Unittests.FSharp_Core.Microsoft_FSharp_Control.AsyncModule.Async.AwaitWaitHandle does not leak memory
Does not look related to this pull request.

dsyme · 2016-07-03T23:21:42Z

CLose/reopen to re-run CI

msftclas · 2016-07-03T23:21:47Z

Hi @wallymathieu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

wallymathieu · 2016-07-06T14:41:35Z

Should we change the title and remove [WIP] ?

dsyme · 2016-07-06T15:19:41Z

src/fsharp/FSharp.Core/prim-types.fs

@@ -3470,6 +3470,12 @@ namespace Microsoft.FSharp.Core
    and 'T option = Option<'T> 


+    [<StructuralEquality; StructuralComparison>]
+    [<CompiledName("FSharpResult`2")>]
+    type Result<'TOk,'TError> = 


Please change to just "T" instead of "TOk"

dsyme · 2016-07-06T15:20:33Z

@wallymathieu removed, thanks. Added one comment above TOk --> T

dsyme · 2016-07-06T23:12:29Z

@KevinRansom @otawfik-ms This is ready to merge.

OmarTawfik · 2016-07-06T23:15:22Z

LGTM 👍

cartermp · 2016-07-07T18:44:11Z

👍

FsharpResult type with a few tests

6e0923a

msftclas added the cla-required label Feb 12, 2016

msftclas added cla-signed and removed cla-required labels Feb 12, 2016

wallymathieu added 2 commits February 12, 2016 22:48

Using instance method string.Contains instead of Seq.contains

af39ca8

Removed redundant declaration

1a7f21d

forki reviewed Feb 14, 2016
View reviewed changes

forki mentioned this pull request Feb 14, 2016

[RFC FS-1004 Discussion] Result type fsharp/fslang-design#49

Closed

wallymathieu changed the title ~~FsharpResult type with a few tests~~ [WIP] FsharpResult type with a few tests Feb 14, 2016

Revert of vs changes to file

e862e75

mexx reviewed Feb 17, 2016
View reviewed changes

Fix for comment about what the file tests

12734f7

dsyme reviewed Jun 25, 2016
View reviewed changes

wallymathieu added 2 commits June 26, 2016 18:40

Added comments and change 'Success' to 'Ok' in Result type

3d324d1

Compilation error and surface area tests

008465a

wallymathieu added 2 commits June 28, 2016 18:59

Merge remote-tracking branch 'Microsoft/master' into fsharp_core_result

6105902

Compilation error

4abfbdb

dsyme closed this Jul 3, 2016

dsyme reopened this Jul 3, 2016

msftclas added the cla-already-signed label Jul 3, 2016

dsyme reviewed Jul 6, 2016
View reviewed changes

dsyme changed the title ~~[WIP] FsharpResult type with a few tests~~ FSharpResult type with a few tests Jul 6, 2016

Renamed TOk to T

7b131d6

dsyme changed the title ~~FSharpResult type with a few tests~~ [RFC FS-1004] FSharpResult type with a few tests Jul 6, 2016

OmarTawfik merged commit aae9904 into dotnet:master Jul 7, 2016

wallymathieu deleted the fsharp_core_result branch July 7, 2016 18:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC FS-1004] FSharpResult type with a few tests #964

[RFC FS-1004] FSharpResult type with a few tests #964

wallymathieu commented Feb 12, 2016 •

edited by dsyme

msftclas commented Feb 12, 2016

msftclas commented Feb 12, 2016

enricosada commented Feb 14, 2016

forki Feb 14, 2016

wallymathieu Feb 14, 2016

forki commented Feb 14, 2016

forki commented Feb 14, 2016

wallymathieu commented Feb 14, 2016

mexx Feb 17, 2016

KevinRansom commented Jun 25, 2016

dsyme Jun 25, 2016 •

edited

dsyme Jun 25, 2016

dsyme commented Jun 25, 2016

wallymathieu commented Jun 26, 2016

dsyme commented Jun 28, 2016

wallymathieu commented Jul 3, 2016 •

edited

dsyme commented Jul 3, 2016

msftclas commented Jul 3, 2016

wallymathieu commented Jul 6, 2016

dsyme Jul 6, 2016

dsyme commented Jul 6, 2016

dsyme commented Jul 6, 2016 •

edited

OmarTawfik commented Jul 6, 2016

cartermp commented Jul 7, 2016

[RFC FS-1004] FSharpResult type with a few tests #964

[RFC FS-1004] FSharpResult type with a few tests #964

Conversation

wallymathieu commented Feb 12, 2016 • edited by dsyme

msftclas commented Feb 12, 2016

msftclas commented Feb 12, 2016

enricosada commented Feb 14, 2016

forki Feb 14, 2016

Choose a reason for hiding this comment

wallymathieu Feb 14, 2016

Choose a reason for hiding this comment

forki commented Feb 14, 2016

forki commented Feb 14, 2016

wallymathieu commented Feb 14, 2016

mexx Feb 17, 2016

Choose a reason for hiding this comment

KevinRansom commented Jun 25, 2016

dsyme Jun 25, 2016 • edited

Choose a reason for hiding this comment

dsyme Jun 25, 2016

Choose a reason for hiding this comment

dsyme commented Jun 25, 2016

wallymathieu commented Jun 26, 2016

dsyme commented Jun 28, 2016

wallymathieu commented Jul 3, 2016 • edited

dsyme commented Jul 3, 2016

msftclas commented Jul 3, 2016

wallymathieu commented Jul 6, 2016

dsyme Jul 6, 2016

Choose a reason for hiding this comment

dsyme commented Jul 6, 2016

dsyme commented Jul 6, 2016 • edited

OmarTawfik commented Jul 6, 2016

cartermp commented Jul 7, 2016

wallymathieu commented Feb 12, 2016 •

edited by dsyme

dsyme Jun 25, 2016 •

edited

wallymathieu commented Jul 3, 2016 •

edited

dsyme commented Jul 6, 2016 •

edited