Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker base image needs be at latest node:14-alpine #651

Merged
merged 3 commits into from
Jan 3, 2022
Merged

fix: docker base image needs be at latest node:14-alpine #651

merged 3 commits into from
Jan 3, 2022

Conversation

hangxingliu
Copy link
Contributor

Hi, I tested use this tools in Docker yesterday and I got the error output:

/opt/vsce/out/package.js:136
    return (translations ?? [])
                          ^

SyntaxError: Unexpected token '?'
    at wrapSafe (internal/modules/cjs/loader.js:915:16)
    at Module._compile (internal/modules/cjs/loader.js:963:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/opt/vsce/out/main.js:27:19)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)

After I read the document and source codes. I found the Node.js version in the Dockerfile is not suitable for the requirement in the README file.
So I updated it from 12 to 14.

Thanks.

@sanemat
Copy link

sanemat commented Jan 3, 2022

@joaomoreno Do you have any concerns?

@joaomoreno joaomoreno merged commit d81a42f into microsoft:main Jan 3, 2022
@joaomoreno joaomoreno added this to the January 2022 milestone Jan 3, 2022
@joaomoreno joaomoreno self-assigned this Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 3, 2022

🎉 This PR is included in version 2.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants