Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few engineering improvements #762

Merged
merged 2 commits into from Oct 23, 2018
Merged

A few engineering improvements #762

merged 2 commits into from Oct 23, 2018

Conversation

ejizba
Copy link
Member

@ejizba ejizba commented Oct 23, 2018

  1. Update typescript version
  2. Update tslint version
    1. One of my favorite new rules is "no-implicit-dependencies" which makes sure you have a dependency listed in "package.json" if you're using it. A month-ish ago we had a problem where the storage package was listed as a devDependency instead of a dependency and this rule would've prevented that
  3. Update to next alpha
  4. Clean up tasks.json/launch.json
  5. Set 'DEBUGTELEMETRY' on launch since gdpr is updated daily now

@ejizba ejizba requested a review from a team as a code owner October 23, 2018 18:43
@ejizba ejizba merged commit 80142b1 into master Oct 23, 2018
@ejizba ejizba deleted the ej/dev branch October 23, 2018 21:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nturinski nturinski nturinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ejizba @nturinski