Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons do not reflect theme #6

Closed
ejizba opened this issue Dec 6, 2017 · 1 comment · Fixed by #249
Closed

Icons do not reflect theme #6

ejizba opened this issue Dec 6, 2017 · 1 comment · Fixed by #249
Milestone
0.5.0

Comments

@ejizba
Copy link
Member

ejizba commented Dec 6, 2017

It's not a HUGE issue because the icons are still visible in both themes, but it would seem to always use the 'light' theme icons. The dark theme icons shouldn't have those white borders
screen shot 2017-12-06 at 1 40 33 pmscreen shot 2017-12-06 at 1 40 14 pm
@StephenWeatherford
Copy link
Contributor

The current icons are all the same, and they're PNGs. Ideally should be using .svgs.

@ejizba ejizba mentioned this issue Nov 19, 2018
Merged
@ejizba ejizba added this to the 0.5.0 milestone Nov 19, 2018
@ejizba ejizba modified the milestones: 0.6.0, 0.5.0 Dec 11, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Upgrade icons to have color and actually be themed microsoft/vscode-azurestorage
2 participants
@StephenWeatherford @ejizba