Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy-paste -> clipboardy #256

Merged
merged 4 commits into from Dec 7, 2018
Merged

copy-paste -> clipboardy #256

merged 4 commits into from Dec 7, 2018

Conversation

PrashanthCorp
Copy link
Contributor

@PrashanthCorp PrashanthCorp commented Dec 6, 2018

Note: The npm install here also updated a few other packages.

Fixes #141

@PrashanthCorp PrashanthCorp requested a review from a team as a code owner December 6, 2018 01:29
3. copy-paste (https://github.com/xavi-/node-copy-paste)
4. glob (https://github.com/isaacs/node-glob)
5. opn (https://github.com/sindresorhus/opn)
3. glob (https://github.com/isaacs/node-glob)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add clipboardy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the opn license was also missing.

Adding that too.

package.json Outdated
@@ -685,10 +684,11 @@
"ms-vscode.azure-account"
],
"dependencies": {
"@types/clipboardy": "^1.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a dev dependency

@ejizba ejizba merged commit 51e2d9c into master Dec 7, 2018
@ejizba ejizba deleted the ps/clipboardy branch December 7, 2018 17:50
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants