This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
Fix some unexplained breakpoints behavior #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changsi-an
approved these changes
Mar 2, 2018
digeff
force-pushed
the
fix_breakpoints_unexplained_behavior
branch
from
20798b5
to
3b7ddbd
Compare
|
@roblourens We want you to take a look before merging this, so we are retargeting this PR to master. |
|
What's the problem exactly? I don't understand the description. |
|
I think this is the wrong fix, the point of keeping unbound bps in this set of handles is that they are the same thing as the bound BPs, and the .set call is recording the change from an unbound BP to a bound BP. What happens when unbound breakpoints are bound and you try to look them up later? I think a better thing to do is to change the unbound ID to not conflict with a real id, like by adding |
added 2 commits
March 5, 2018 14:40
|
Applied feedback |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the breakpointId is a number, these two types of key can get incorrectly mixed with each other.