New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some unexplained breakpoints behavior #296

Merged
merged 4 commits into from Mar 6, 2018

Conversation

Projects
None yet
3 participants
@digeff
Copy link
Contributor

digeff commented Mar 2, 2018

If the breakpointId is a number, these two types of key can get incorrectly mixed with each other.

@digeff

This comment has been minimized.

Copy link
Contributor

digeff commented Mar 2, 2018

@digeff

This comment has been minimized.

Copy link
Contributor

digeff commented Mar 2, 2018

@digeff digeff changed the base branch from feature/telemetry to master Mar 2, 2018

@digeff digeff changed the base branch from master to feature/telemetry Mar 2, 2018

@digeff digeff changed the base branch from feature/telemetry to master Mar 2, 2018

@digeff digeff force-pushed the digeff:fix_breakpoints_unexplained_behavior branch from 20798b5 to 3b7ddbd Mar 2, 2018

@digeff

This comment has been minimized.

Copy link
Contributor

digeff commented Mar 2, 2018

@roblourens We want you to take a look before merging this, so we are retargeting this PR to master.

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Mar 5, 2018

What's the problem exactly? I don't understand the description.

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Mar 5, 2018

I think this is the wrong fix, the point of keeping unbound bps in this set of handles is that they are the same thing as the bound BPs, and the .set call is recording the change from an unbound BP to a bound BP. What happens when unbound breakpoints are bound and you try to look them up later? I think a better thing to do is to change the unbound ID to not conflict with a real id, like by adding _unbound to the number or something.

digeff added some commits Mar 5, 2018

@digeff

This comment has been minimized.

Copy link
Contributor

digeff commented Mar 5, 2018

Applied feedback

@roblourens roblourens merged commit 51e8e5d into Microsoft:master Mar 6, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.

@digeff digeff deleted the digeff:fix_breakpoints_unexplained_behavior branch Mar 6, 2018

@roblourens roblourens added this to the March 2018 milestone Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment