Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ionic cordova namespaced commands updated on CLIv3 #280

Merged
merged 1 commit into from May 26, 2017

Conversation

neilor
Copy link
Contributor

@neilor neilor commented May 24, 2017

In a try to add support for newly changes on Ionic CLI v3 that adds Cordova commands to an namespace, I've added an helper that checks presence of new @ionic/cordova-cli-plugin(CHANGELOG) in dev dependencies.

That helper is used for prepend "cordova" namespace on args when starting Cordova command.

I hope that I've contribute until here.

This fixes #279

@msftclas
Copy link

@neilor,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

@neilor, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@vladimir-kotikov
Copy link

@neilor thank you for the PR. We'll take a look at this shortly.

@terbooter
Copy link

terbooter commented May 26, 2017

@vladimir-kotikov,
I tested this PR on Ionic CLI v3.2 and on pure cordova project. It seems work fine.

@vladimir-kotikov vladimir-kotikov merged commit d47f4b7 into microsoft:master May 26, 2017
@vladimir-kotikov
Copy link

@terbooter thanks 👍

@mlibbyrh
Copy link

I tested Ionic Cordova's launch.json using Ionic 3 and for Android. Android/IOS work great running in a browser. Each saved software change automatically builds and displays. Nice!

However, I am not able to Run Android on Device as I was able to do in Ionic 2. I was hoping this fix would address that too.

Thanks for what you did though.

@vladimir-kotikov vladimir-kotikov added this to the 1.2.8 milestone Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ionic CLI v3 moved commands from ionic to ionic cordova
5 participants