Intellisense suggestions don't appear and formatting documents has no effect #1396
Labels
bug
fixed
Check the Milestone for the release in which the fix is or will be available.
Language Service
Milestone
Comments
|
Does Go to Definition work? I would assume the formatting is failing because the main input thread is stuck on the IntelliSense operation. @bobbrow Any more ideas? |
sean-mcmanus
added
the
more info needed
|
Goto definition/declaration and peek definition/declaration both work. |
sean-mcmanus
removed
the
more info needed
|
Could you temporarily change your C_Cpp.loggingLevel to 6 and then do a Format Document and look at the C/C++ output window? It should give logging about formatting. Do you see where the results are getting returned incorrectly from the output? I assume these error don't happen on a simple C++ file with just |
sean-mcmanus
added
the
more info needed
|
I changed the No output appears when I try to do a Format Document. |
|
The Information setting won't be good enough, because we don't log the formatting diagnostics in that case, because it outputs a lot of text. It needs to be at least "6" -- can you ignore the error? I assume you mean the green squiggle in the settings.json -- that can be ignored. The 6 setting is a hidden value. |
I've skipped a lot of text that was repetitive, but I can add it if you want. |
|
Also, I noticed that restarting VSCode makes intellisense available for a brief amount of time. |
|
The formatting input and output appear correct, but the output is not changed. Do you expect the raw output to be different? You may need to change your .clang-format settings if you want different results. However, the output "Formatting diffed output" is missing. Did you omit that? What I'm looking for is the point at which the formatting is going incorrect. For the IntelliSense issue, it looks like our parser is crashing with the parser.cpp file. Can you add the crash log at ~/Library/Logs/DiagnosticReports for the Microsoft.VSCode.CPP.IntelliSense.Msvc.darwin process or just paste the call stack of the crashing thread? |
|
About the formatting, the input and output may be correct but the output doesn't make it to the actual file. I haven't changed any settings related to formatting. |
|
This is a crash report for |
|
And, it looks like the crash above is probably from setting the logging level to the number 6 instead of the string "6". I will make a fix for that. |
There are 20 more crash reports. |
|
Thanks. This crash is a little less straightforward. Are you able to share any source code so we can reproduce this crash in-house? |
|
Yeah sure, https://github.com/nabeelomer/Guacamole |
|
Also, as of my most recent commit, everything works perfectly, I can format documents and Intellisense is available. |
|
Ok, I was about to say that I just cloned your repo and didn't see any issues. |
|
Yikes, that crash is with set_logging_level of the main process -- I think we have a fix for that (thanks for reporting that). It looks like you're passing in the number 6 instead of the string "6"? Are there any crashes with the IntelliSense.Msvc.darwin process? Do you mean the input and raw output appear to be correctly formatted but they don't match what is shown in the file? It sounds like the "Formatting diffed output" step might be failing. Do you have log output that shows that? We do a diff of the output with our internal document representation. Oh, this message was delayed for many hours...didn't see Bob's response. |
|
The "add_expression_to_index" crash is a known issue -- it actually our most common IntelliSense crash on Mac. However, we don't have a repro yet, so any help getting an isolated repro would help in fixing it. I assume it resulted in some temporary/invalid code while typing...we handle those scenarios via auto-restarting the crashed IntelliSense process after additional edits, so users may not even notice the crash. |
|
I'll try going back commit by commit and reproducing the issue. |
sean-mcmanus
added
fixed
|
The add_expression_to_index crash has been fixed with 0.16.0 -- well, there are still some very rare scenarios where the function can crash, but the high hitting scenario was fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
VSCode Insiders v1.20MacOS v10.13.2C/C++ tools v0.14.5VSCode cpptools doesn't show Intellisense suggestions and trying to format documents doesn't work either.
The following text appears in the output window:
**Activity Monitor showing the Intellisense process**The text was updated successfully, but these errors were encountered: