Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not correctly detecting errors #2763

Closed
BigfootN opened this issue Nov 2, 2018 · 3 comments
Closed

Not correctly detecting errors #2763

BigfootN opened this issue Nov 2, 2018 · 3 comments
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service parser
Milestone

Comments

@BigfootN
Copy link

BigfootN commented Nov 2, 2018

Type: LanguageService

Describe the bug

  • OS and Version: Archlinux

  • VS Code Version: 1.28.2

  • C/C++ Extension Version: 0.20.1

  • Other extensions you installed (and if the issue persists after disabling them):

    • Gruvbox Themes
    • Material Theme
    • Vim
  • A clear and concise description of what the bug is.

Hello,

I noticed that the extension doesn't seem to notice all the errors and warnings in the code. For example, when writing this:

char **a;

a = "string";

It doesn't return any warning or error. Other than that, it seems to work fine.

I'm using compile_commands.json with the -Wall -Werror -Wextra flags enabled, and generated from cmake.

Thank you very much in advance.

@sean-mcmanus sean-mcmanus added bug Language Service fixed Check the Milestone for the release in which the fix is or will be available. parser labels Nov 2, 2018
@sean-mcmanus sean-mcmanus added this to the December 2018 milestone Nov 2, 2018
@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Nov 2, 2018

Thanks for reporting this. The issue has already been fixed for our pending 0.21.0-insiders release next week. I assume you're using C++ though (C should not give an error in your case)...well, if you expect a compiler warning in C, then that may be fixed after we add warning support (#828 ).

@BigfootN
Copy link
Author

BigfootN commented Nov 2, 2018

Thank you very much for your quick response.

I was using C in fact.

Thank you for this great extension.

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Nov 2, 2018

Yeah, even with the "hidden" warnings enabled our parser doesn't show a warning for C files, so this will only be fixed for C++ in our next release.

UPDATE:

Should be fixed (for C++, not C) with 0.21.0-insiders (auto installed if "C_Cpp.updateChannel": "Insiders" is set, or the offline vsix). Let us know if you find any problems with it.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service parser
Projects
None yet
Development

No branches or pull requests

2 participants