Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CSS triggerPropertyValueCompletion setting #149

Merged
merged 4 commits into from
Mar 7, 2019
Merged

Implement CSS triggerPropertyValueCompletion setting #149

merged 4 commits into from
Mar 7, 2019

Conversation

svipas
Copy link
Contributor

@svipas svipas commented Mar 4, 2019

When this PR will be merged, I will create a setting inside css-language-features which is in vscode repo.

Related to: microsoft/vscode#68495

Copy link
Contributor

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do some cleanup of the long tesetCompletionFor function later. For now just add another parameter for the setting to expected for testing your changes.

src/test/css/completion.test.ts Outdated Show resolved Hide resolved
src/services/cssCompletion.ts Outdated Show resolved Hide resolved
@svipas
Copy link
Contributor Author

svipas commented Mar 6, 2019

@octref Could you review again? I created tests and made some small changes.

Copy link
Contributor

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, small nitpick. Thanks!

src/services/cssCompletion.ts Outdated Show resolved Hide resolved
@svipas
Copy link
Contributor Author

svipas commented Mar 7, 2019

@octref Let me know if I can create a PR in VS Code to add css.completion.triggerPropertyValueCompletion. But first I need your help to create a description for it 😄

package.json

"css.completion.triggerPropertyValueCompletion": {
	"type": "boolean",
	"scope": "resource",
	"default": true,
	"description": "%css.completion.triggerPropertyValueCompletion.desc%"
},

package.nls.json

"css.completion.triggerPropertyValueCompletion.desc": "TODO: desc",

@octref octref merged commit 9a873c6 into microsoft:master Mar 7, 2019
@octref
Copy link
Contributor

octref commented Mar 7, 2019

Something like "By default, VS Code triggers property value completion after selecting a CSS property. Use this setting to disable this behavior." would do.

@octref octref added this to the March 2019 milestone Mar 7, 2019
@svipas svipas deleted the css-trigger-property-value-completion branch March 8, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants