Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: flow-root for display property completion #29

Closed

Conversation

praveenpuglia
Copy link
Contributor

@praveenpuglia praveenpuglia commented May 16, 2017

flow-root is now a supported value for display which essentially replaces the clearfix hack. It's available in Chrome 58 and FF53 onwards.

It didn't appear in VSCode completion, so I thought I would make a PR here.

@msftclas
Copy link

@praveenpuglia,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@aeschli
Copy link
Contributor

aeschli commented Jul 4, 2017

@praveenpuglia Hi Praveen, browsers.js is generated from css-schema.xml. I made your suggested change there, regenerated and pushed. I hope that's ok for you. Thanks for the PR!

@aeschli aeschli closed this Jul 4, 2017
aeschli added a commit that referenced this pull request Jul 4, 2017
@praveenpuglia
Copy link
Contributor Author

I didn't know that. Thanks for updating in right place. :)

@praveenpuglia praveenpuglia deleted the display-flow-root branch July 7, 2017 03:46
@aeschli aeschli added this to the July 2017 milestone Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants