Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Colors Level 4 - 4 & 8 digit hex values #38

Merged
merged 2 commits into from
Jul 17, 2017

Conversation

praveenpuglia
Copy link
Contributor

fix: #32

Note.
This doesn't show any color in small color box in the editor beside the color definition because css itself doesn't support it at the moment.

We could get around that problem by detecting and converting #rgba or #rrggbbaa values to rgba() values before they are added to css/client/src/colorDecorators.ts.

@aeschli - please correct me if I missed something. Very new to the source code.

@msftclas
Copy link

@praveenpuglia,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@aeschli
Copy link
Contributor

aeschli commented Jul 17, 2017

Looks good. Can you also provide a fix for the color decorations (in vscode)? As you write, it needs to be detected and converted to 'rgba(...)' There is should also be fixed at https://github.com/Microsoft/vscode/blob/master/extensions/html/client/src/colorDecorators.ts#L114

@aeschli aeschli merged commit 2729975 into microsoft:master Jul 17, 2017
@aeschli aeschli added this to the July 2017 milestone Jul 17, 2017
@praveenpuglia
Copy link
Contributor Author

@aeschli - I am working on a fix. Thinking of adding a converter function in the colorDecorators.ts itself. Is there a better suited for these sort of helpers?

@praveenpuglia
Copy link
Contributor Author

@aeschli - made this commit to my own fork. Can you please check it once?
praveenpuglia/vscode@434beab

Also, couldn't understand where do I write tests for it.

@egamma
Copy link
Member

egamma commented Jul 24, 2017

@praveenpuglia fyi, we have vacation time over hear so response time will we slower.

@praveenpuglia
Copy link
Contributor Author

@egamma - sure. Have a great one! 👍 😊

@praveenpuglia praveenpuglia deleted the css-colors-4-hex-codes branch August 11, 2017 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide support for non standard CSS properties and restrictions in VSCode
4 participants