Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow requests to specify formatting hints. #82

Closed

Conversation

richardstanton
Copy link
Member

Add optional formatting object to allow customization on how values and stack frames are displayed.

@weinand
@jacdavis @gregg-miskelly @andrewcrawley @tzwlai

@msftclas
Copy link

Hi @richardstanton, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Richard Stanton). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@weinand
Copy link
Contributor

weinand commented Nov 2, 2016

@richardstanton before sending a PR please create an issue that explains the protocol additions and where we can discuss it.

@richardstanton
Copy link
Member Author

@weinand I created an issue for this. Sorry, I misunderstood the process for protocol changes. #84

@weinand
Copy link
Contributor

weinand commented Nov 4, 2016

@richardstanton great, thanks a lot. In VS Code we always try to have a feature discussion before a PR is created. With this we try to avoid that a PR diverges too much from our own plans and thinking.

@weinand
Copy link
Contributor

weinand commented Dec 1, 2016

@richardstanton thanks for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants