Support workspace folders for the language server's settings #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook the VS Code settings to the proposed workspace/configuration language server protocol request. This will allow the language server to provide different validation results based on the settings of where the Dockerfile resides. Signed-off-by: Remy Suen <remy.suen@gmail.com>
|
(i'm on vacation, this may take me a few days to look at... sorry) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS Code's workspace feature will now allow resources to have settings that are scoped to the given resource's folder hierarchy. We need to add support to the
workspace/configurationlanguage server protocol request that's currently being proposed so that the extension can send changes to scoped settings to the language server.