Improve docker-machine documentation. #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note need for DOCKER_CERT_PATH when using TLS.
| @@ -124,6 +124,8 @@ By default, Docker runs as the root user, requiring other users to access it wit | |||
|
|
|||
| The default connection of the extension is to connect to the local docker daemon. You can connect to a docker-machine instance if you launch Visual Studio Code and have the DOCKER_HOST environment variable set to a valid host or if you set the `docker.host` configuration setting. | |||
|
|
|||
| If the docker daemon is using TLS, the DOCKER_CERT_PATH environment variable must also be set (e.g. `$HOME\.docker\machine\machines\default`). | |||
There was a problem hiding this comment.
Much thanks for this contribution.
Should you point to (https://docs.docker.com/machine/reference/env/) for more information?
There was a problem hiding this comment.
I'll add this after the merge.
StephenWeatherford
approved these changes
Jul 25, 2018
|
@mikepatrick Thanks! Really appreciate this contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note the need for a DOCKER_CERT_PATH environment variable when using TLS.
The
docker-machinesection of the README calls out the need for a DOCKER_HOST environment variable, but does not mention the DOCKER_CERT_PATH environment variable.Failure to have DOCKER_CERT_PATH set when using TLS causes strange looking TLS errors, which are only reported to the user as "Could not connect to docker daemon".
This seems to cause a fair amount of confusion; see here, here, and here.