New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place VS Code inside insiders/stable sub-folders of .vs-test #97

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
2 participants
@DanTup
Copy link
Contributor

DanTup commented Mar 8, 2018

This avoids files overwriting each other from each version on Windows which might cause issues if you run tests for stable, then insiders, then stable again.

Slightly related to #94.

I've tested on Windows and Mac OS but don't have easy access to a Linux machine (the change is fairly trivial, however).

This could break people if they're relying on the executable being in a specific location in other scripts, but this seems very unlikely (and the fix is fairly obvious if it does break you).

Place VS Code inside insiders/stable sub-folders of .vs-test
This avoids files overwriting each other from each version on Windows which might cause issues if you run tests for stable, then insiders, then stable again.
@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Mar 8, 2018

LGTM

@bpasero bpasero merged commit c78ba1f into Microsoft:master Mar 8, 2018

1 check passed

license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment