Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Place VS Code inside insiders/stable sub-folders of .vs-test #97

Merged
merged 1 commit into from Mar 8, 2018

Conversation

DanTup
Copy link
Contributor

@DanTup DanTup commented Mar 8, 2018

This avoids files overwriting each other from each version on Windows which might cause issues if you run tests for stable, then insiders, then stable again.

Slightly related to #94.

I've tested on Windows and Mac OS but don't have easy access to a Linux machine (the change is fairly trivial, however).

This could break people if they're relying on the executable being in a specific location in other scripts, but this seems very unlikely (and the fix is fairly obvious if it does break you).

This avoids files overwriting each other from each version on Windows which might cause issues if you run tests for stable, then insiders, then stable again.
@bpasero
Copy link
Member

bpasero commented Mar 8, 2018

LGTM

@bpasero bpasero merged commit c78ba1f into microsoft:master Mar 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants