-
Notifications
You must be signed in to change notification settings - Fork 27
Support to repository name including dots ( fixes #13 ) #17
Conversation
@wraith13, |
Would it be simpler to just match |
Yes, I think so. |
If you get a chance to update the PR, I'll be happy to merge it. |
Thanks! |
Sorry! I misunderstood that you said. ( My close friend informed to me. ) |
I fixed. How about this? |
Don't all GitHub remote's have the |
Sorry, I am not familiar with git. |
https://stackoverflow.com/questions/2514859/regular-expression-for-git-repository |
How about this time? |
Looks good, except I just found a remote without the '.git' suffix. Maybe that has become optional at some point? |
I do not know. However, I think other tools also expect(need) '.git'. First of all, in accordance with KISS principle, adopt this simple code. |
Let's remove |
It's a |
Thanks @wraith13 ! |
I fixed #13 .
Let me know if there are any problem.