Run on save actions only for active documents, fixes #2202

microsoft · Dec 30, 2018 · cf0a61c · cf0a61c
1 parent 7791044
commit cf0a61c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/goFormat.ts b/src/goFormat.ts
@@ -13,7 +13,11 @@ import { sendTelemetryEvent, getBinPath, getToolsEnvVars, killTree } from './uti
 
 export class GoDocumentFormattingEditProvider implements vscode.DocumentFormattingEditProvider {
 
-	public provideDocumentFormattingEdits(document: vscode.TextDocument, options: vscode.FormattingOptions, token: vscode.CancellationToken): Thenable<vscode.TextEdit[]> {
+	public provideDocumentFormattingEdits(document: vscode.TextDocument, options: vscode.FormattingOptions, token: vscode.CancellationToken): vscode.ProviderResult<vscode.TextEdit[]> {
+		if (vscode.window.visibleTextEditors.every(e => e.document.fileName !== document.fileName)) {
+			return [];
+		}
+
 		let filename = document.fileName;
 		let goConfig = vscode.workspace.getConfiguration('go', document.uri);
 		let formatTool = goConfig['formatTool'] || 'goreturns';

diff --git a/src/goMain.ts b/src/goMain.ts
@@ -560,7 +560,9 @@ function startBuildOnSaveWatcher(subscriptions: vscode.Disposable[]) {
 		if (document.languageId !== 'go') {
 			return;
 		}
-		runBuilds(document, vscode.workspace.getConfiguration('go', document.uri));
+		if (vscode.window.visibleTextEditors.some(e => e.document.fileName === document.fileName)) {
+			runBuilds(document, vscode.workspace.getConfiguration('go', document.uri));
+		}
 	}, null, subscriptions);
 }