Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

References codelens shows 0 when guru fails #1336

Closed
ramya-rao-a opened this issue Nov 15, 2017 · 2 comments
Closed

References codelens shows 0 when guru fails #1336

ramya-rao-a opened this issue Nov 15, 2017 · 2 comments

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Nov 15, 2017 •
edited

The codelens for references uses the guru tool behind the scenes to provide references.
When guru fails, the codelens shows "0 references" instead of alluding to the fact that the tool has failed behind the scenes

The console shows failures from guru with details on the command being called with args as well as a call stack. The call stack is related to node and the child process that was spawned for guru and is pointless

cc @JeffreyRichter
@ramya-rao-a
Copy link
Contributor Author

With 68a8d1f, the below changes are made:

  • The codelens would say "Error finding references" instead of "0 references" if there was error in running the guru tool
  • When there is error running the guru tool, the console will show the command and the args being passed as before. The call stack related to node and child process will not be shown

ramya-rao-a added a commit that referenced this issue Nov 15, 2017
@ramya-rao-a
Remove noise from errmsg for Go To Definition feature #1336
d20b28e
@ramya-rao-a
Copy link
Contributor Author

The fix is out in the latest update to the Go extension (0.6.69)

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ramya-rao-a