Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Set Diagnostic.source for generated diagnostics #2101

Closed
segevfiner opened this issue Nov 5, 2018 · 1 comment · Fixed by #2109
Closed

Set Diagnostic.source for generated diagnostics #2101

segevfiner opened this issue Nov 5, 2018 · 1 comment · Fixed by #2109

Comments

@segevfiner
Copy link
Contributor

This appears in square brackets in front of the "problem" in the problems view. It should be set to go for diagnostics generated from building go code (go build). And maybe the name of the linter for linters.

See also: #2100
@segevfiner segevfiner mentioned this issue Nov 5, 2018
Closed
segevfiner added a commit to segevfiner/vscode-go that referenced this issue Nov 9, 2018
@segevfiner
Split up the DiagnosticCollections per tool type
3989532 
Also set setting diagnostic.source

Fixes microsoft#2100, fixes microsoft#2101
@segevfiner segevfiner mentioned this issue Nov 9, 2018
Merged
ramya-rao-a pushed a commit that referenced this issue Nov 13, 2018
@segevfiner @ramya-rao-a
Split up the DiagnosticCollections per tool type (#2109)
03dc46a 
* Split up the DiagnosticCollections per tool type

Also set setting diagnostic.source

Fixes #2100, fixes #2101

* Simplify handleDiagnosticErrors a bit

* Also dedupe build & lint warnings together

* Clear all diagnostics in runBuilds

* Small refactorings

* Revert test.only
@ramya-rao-a
Copy link
Contributor

This feature is now available in the latest version of the Go extension (0.8.0)
Thanks @segevfiner!

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split up the DiagnosticCollections per tool type segevfiner/vscode-go
2 participants
@ramya-rao-a @segevfiner