Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Defined alternate tools should be skipped by the Install/Update Tools command #3024

Closed
jlucktay opened this issue Feb 1, 2020 · 2 comments · Fixed by #3046
Closed

Defined alternate tools should be skipped by the Install/Update Tools command #3024

jlucktay opened this issue Feb 1, 2020 · 2 comments · Fixed by #3046

Comments

@jlucktay
Copy link

jlucktay commented Feb 1, 2020

Is your feature request related to a problem? Please describe.
If an alternate location for a tool is already defined (e.g. "go.alternateTools": { "gometalinter": "/usr/local/bin/golangci-lint" }) the Install/Update Tools command will still install the same command at another location.

Describe the solution you'd like
When such an alternate definition is already in place for any tool, Install/Update Tools should skip said tool.

Additional context
In my own circumstance, I also have "go.toolsGopath": "~/vscode-go" set, to reduce clutter by keeping VSCode's tools out of my ~/go/bin directory.

@ramya-rao-a
Copy link
Contributor

Fair point, PRs are most welcome to make this change to have the Go: Install/Update Tools command skip such tools.

Code Pointers:

hyangah added a commit to hyangah/vscode-go-old that referenced this issue Feb 13, 2020
Skip them from the Install/Update Tools command.

Tools listed in go.alternateTools are supposed to be maintained
by the users.

Fixes microsoft#3024
hyangah added a commit to hyangah/vscode-go-old that referenced this issue Feb 13, 2020
Skip them from the Install/Update Tools command.

Tools listed in go.alternateTools are supposed to be maintained
by the users.

Fixes microsoft#3024
@ramya-rao-a
Copy link
Contributor

This should be fixed in the latest version (0.13.1) of the extension.

Thanks for reporting @jlucktay!

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants