Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Use more icons in autocomplete box #1961

Merged
merged 1 commit into from
Oct 12, 2018
Merged

Conversation

cezarsa
Copy link
Contributor

@cezarsa cezarsa commented Oct 3, 2018

This PR changes the autocomplete dialog to use more icons, distinguishing structs, interfaces and other types.

Before:
screen shot 2018-10-02 at 22 09 45

After:
screen shot 2018-10-02 at 22 08 13

The following code is used in the autocomplete example above:

type BoolType bool
const Const = 8
func Func() {}
type Interface interface{}
type StringType string
type Struct struct{}
var Var = 9

@ramya-rao-a
Copy link
Contributor

Sweet! Just curious, why use Class icon for struct and Struct icon for other types?

Also, dont forget to register for the Microsoft Hacktoberfest :)

@cezarsa
Copy link
Contributor Author

cezarsa commented Oct 11, 2018

So, the reasoning for Go Structs to use the Class icon was because Go structs might look a bit more like classes in other languages since they can have methods. Also, C++ structs use the Class icon as well.

Using Struct icons for other types was arbitrary really, I didn't know exactly what icon to use on them. After taking a look at how the C extension handles this I found out that it uses the Enum icon for typedef declarations. Maybe I should also switch other types to the Enum icon for consistency?

@ramya-rao-a ramya-rao-a merged commit c330245 into microsoft:master Oct 12, 2018
@ramya-rao-a
Copy link
Contributor

Ah, ok. That makes sense.
I dont have a preference for Enum icon over Struct icon, so let's go with what you have at the moment.
If we get any feedback around this, then we can act on it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants