Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Handle unexpected proxy query results gracefully #3205

Merged
merged 1 commit into from
Apr 25, 2020

Conversation

neclepsio
Copy link
Contributor

@neclepsio neclepsio commented Apr 24, 2020

When the proxy contacted for the released gopls version list does not
respond following the Go module proxy protocol but return unexpected
contents (e.g. login page) semver parsing will fail, trigger an exception,
and cause the language server client not to start.

Fixes #3204

@hyangah
Copy link
Contributor

hyangah commented Apr 24, 2020

Thanks for the fix!
Can you provide the PR title & description? Something like

Handle unexpected proxy query results gracefully

When the proxy contacted for the released gopls version list does not
respond following the Go module proxy protocol but return unexpected
contents (e.g. login page) semver parsing will fail, trigger an exception,
and cause the language server client not to start.
 
Fixes #3204

The linked issue in the title has the full description already, but it's always nice to have a descriptive commit message - unless @ramya-rao-a will manually edit the commit message before merge.

@neclepsio neclepsio changed the title Fixes #3204 Handle unexpected proxy query results gracefully Apr 24, 2020
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is your first PR contribution to this project @neclepsio
Thanks & Welcome!

@ramya-rao-a ramya-rao-a merged commit 65ede88 into microsoft:master Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gopls does not start behind a blocking proxy
3 participants