fix feature break from October VSCode insider #87
Conversation
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
src/configurationProvider.ts
Outdated
| import TelemetryReporter from "vscode-extension-telemetry"; | ||
| import * as commands from "./commands"; | ||
|
|
||
| export class JavaConfigurationProvider implements vscode.DebugConfigurationProvider { |
There was a problem hiding this comment.
JavaDebugConfigurationProvider
| } | ||
|
|
||
| // Try to add all missing attributes to the debug configuration being launched. | ||
| public resolveDebugConfiguration(folder: vscode.WorkspaceFolder | undefined, config: vscode.DebugConfiguration, token?: vscode.CancellationToken): |
There was a problem hiding this comment.
This method is not marked async yet call async meethods
There was a problem hiding this comment.
This is VSCode API built-in methods. No need to change it to async. because the result vscode.ProviderResult<vscode.DebugConfiguration> could be T or Thenable<T>.
Besides, changing the method declaration to async will ask us to modify the return value to Promise<T>, too.
There was a problem hiding this comment.
That's the point. If you mark as async, then the caller will know how to deal with it. If you don't provide the same behavior as method signature, the behavior will be undefined in some cases.
src/configurationProvider.ts
Outdated
| // Try to add all missing attributes to the debug configuration being launched. | ||
| public resolveDebugConfiguration(folder: vscode.WorkspaceFolder | undefined, config: vscode.DebugConfiguration, token?: vscode.CancellationToken): | ||
| vscode.ProviderResult<vscode.DebugConfiguration> { | ||
| return this.guessAndValidateDebugConfiguration(folder, config); |
There was a problem hiding this comment.
Normally in this sitation, we will call method heuristic....
|
VSCode will drop these debug config items in the following October milestone: |
| config.classPaths = await resolveClasspath(config.mainClass, config.projectName); | ||
| } | ||
| if (!config.classPaths || !Array.isArray(config.classPaths) || !config.classPaths.length) { | ||
| vscode.window.showErrorMessage("Cannot resolve the classpaths automatically, please specify the value in the launch.json."); |
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
…ow exception for Object Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
#82