Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors from rename still not shown in VSCode #329

Closed
Gama11 opened this issue Mar 27, 2018 · 3 comments
Closed

Errors from rename still not shown in VSCode #329

Gama11 opened this issue Mar 27, 2018 · 3 comments
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@Gama11
Copy link
Contributor

Gama11 commented Mar 27, 2018

Rename errors passed from a language server still don't seem to reach VSCode. Original issue: #220. This is using 1.21.0 and vscode-languageclient 4.0.0:

I'm not sure which of the two is at fault, but this error shows up in the dev console after a failed rename:

The example from microsoft/vscode#37808 seems to work as expected.


The issue can easily be reproduced outside of the Haxe extension by making some adjustments to the lsp-sample:

https://github.com/Gama11/vscode-extension-samples/commit/1280db4df548273bef8ba1d9beb1115c611a2ba5

@dbaeumer dbaeumer added the bug Issue identified by VS Code Team member as probable bug label Apr 3, 2018
@dbaeumer dbaeumer added this to the April 2018 milestone Apr 3, 2018
@dbaeumer
Copy link
Member

dbaeumer commented Apr 3, 2018

See also microsoft/vscode#37808

@Gama11
Copy link
Contributor Author

Gama11 commented Apr 3, 2018

Not sure what you mean? I already linked to that issue:

The example from microsoft/vscode#37808 seems to work as expected.

@dbaeumer
Copy link
Member

dbaeumer commented Apr 4, 2018

That was for me :-)

@vscodebot vscodebot bot locked and limited conversation to collaborators May 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants