Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code does not italicize text when it is quoted #20

Closed
quanticle opened this issue Jun 20, 2018 · 3 comments
Closed

VS Code does not italicize text when it is quoted #20

quanticle opened this issue Jun 20, 2018 · 3 comments
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@quanticle
Copy link

  • VS Code version: 1.24.1
  • OS: Ubuntu 18.04

Steps to reproduce:

  1. Create a markdown file
  2. Add the following text: *"quoted emphasis"*

Expected result: *"quoted emphasis"*

Actual result: *"quoted emphasis"*

This occurs on the latest release and preview builds.

@quanticle
Copy link
Author

This might be related to problems rendering bold and italics when they are adjacent, but I'm not sure.

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jun 20, 2018
@quanticle
Copy link
Author

quanticle commented Jun 20, 2018

I think the issue is in how we detect the opening. According to line 317 of markdown.tmLanguage.base.yaml, the expression used to detect the start of an italicized block is (\*\b|\b_)(?=\S). However, if I'm reading the reference on JS word boundaries correctly, single and double quotes don't appear to qualify as word boundaries.

I tried several other sequences:

  • */foo/*
  • *(bar)*
  • *$hello$*

None of those italicize in VSCode either, even though Github and other editors, such as Atom, italicize them, which seems to confirm my hypothesis that \b is too restrictive when detecting the start of an italicized block. However, I'm not sure what the correct set of characters is. For example, do we want to italicize *<baz>*?

@tanhakabir
Copy link
Contributor

Can't repro anymore in stable 1.53.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants