Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency to SDB #15

Merged
merged 4 commits into from
Feb 26, 2017
Merged

Remove dependency to SDB #15

merged 4 commits into from
Feb 26, 2017

Conversation

t-h-e
Copy link
Contributor

@t-h-e t-h-e commented Nov 1, 2016

Neccessary packages have been added to packages.config
Some code from SDB is reused and was added to src/sdb
Removed SDB from project

@t-h-e t-h-e mentioned this pull request Nov 1, 2016
Closed
@weinand weinand self-assigned this Dec 9, 2016
@weinand
Copy link
Contributor

weinand commented Feb 24, 2017

@t-h-e Hi! Sorry for the late response...

What is the purpose/benefit of removing the dependency on SDB?

@weinand weinand added this to the February 2017 milestone Feb 26, 2017
@weinand weinand merged commit 300a127 into microsoft:master Feb 26, 2017
@weinand
Copy link
Contributor

weinand commented Feb 26, 2017

@t-h-e thanks for the PR!
On top of that I've removed lots of dead wood.

@t-h-e
Copy link
Contributor Author

t-h-e commented Feb 27, 2017

I should have linked the following issue: #12

@weinand
Copy link
Contributor

weinand commented Feb 27, 2017

@t-h-e oh, I see. I forgot about #12.
Could you try mono-debug on Windows and verify that it works for?
Then we could close #12.

@t-h-e
Copy link
Contributor Author

t-h-e commented Feb 27, 2017

works for me :)

@weinand
Copy link
Contributor

weinand commented Feb 27, 2017

great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@weinand weinand

Labels
None yet
Projects
None yet
Milestone
February 2017
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@t-h-e @weinand