Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Language Flavor notification support to allow disabling MSSQL processing on a per-file basis #978

Closed
kevcunnane opened this issue Sep 5, 2017 · 1 comment
Assignees

Comments

@kevcunnane
Copy link
Contributor

We implemented Language Flavor notifications in the backend so that we can filter out SQL files we don't want to be treated as MSSQL. This is useful for dynamically skipping files if you have a mix of MSSQL and non-MSSQL files with a .sql extension. We should implement the front-end to:

  • Show a button with MSSQL or Other SQL as the option
  • On click, allow user to apply the filter and send the notification

This will mean users can easily opt out of the processing for each file and save some pain. We have a number of issues raised related to this.

@kevcunnane kevcunnane added the task label Sep 5, 2017
@kevcunnane kevcunnane self-assigned this Sep 5, 2017
@kevcunnane kevcunnane added this to the MSSQL 1.2 Release milestone Sep 5, 2017
@klukiyan
Copy link

klukiyan commented Sep 5, 2017

@kevcunnane , very nice idea about MSSQL button.
Before I switched to VScode, I quite enjoyed the option in sublime text that when working with MS SQL I could select T-SQL syntax language, and when working with MySQL I've used the MySQL syntax language. Both appeared as such in the top right corner where you select the language.

kevcunnane added a commit that referenced this issue Sep 19, 2017
Fixes #978: adds a new status indicator for Language Flavor so that users can choose MSSQL or None for provider type. If None then MSSQL intellisense and syntax checking are skipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants