Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom editor will randomly not use the custom editor #988

Closed
rchiodo opened this issue Jun 9, 2020 · 5 comments
Closed

Custom editor will randomly not use the custom editor #988

rchiodo opened this issue Jun 9, 2020 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Jun 9, 2020

Enable custom editor
Create a blank notebook

This comes up:
image

We might fix this by using openWith instead of open [Edit], we already use openWith so that's not the problem.

@rchiodo rchiodo changed the title Custom editor does will randomly not use the custom editor Custom editor will randomly not use the custom editor Jun 9, 2020
@rchiodo
Copy link
Contributor Author

rchiodo commented Jun 15, 2020

Blocked on:
microsoft/vscode#100238

@greazer
Copy link
Contributor

greazer commented Jul 28, 2020

Looks like Matt thinks this is something we can address.

@DavidKutu DavidKutu self-assigned this Jul 29, 2020
@DavidKutu DavidKutu removed their assignment Aug 5, 2020
@rchiodo rchiodo self-assigned this Aug 6, 2020
@rchiodo
Copy link
Contributor Author

rchiodo commented Aug 7, 2020

In VS code insiders, the new notebook stuff is fixed.

Still left to do:

  • Check undo for all operations. Seems to break on move cells

@rchiodo
Copy link
Contributor Author

rchiodo commented Aug 10, 2020

This is only working in VS code insiders at the moment.

@IanMatthewHuff IanMatthewHuff self-assigned this Aug 13, 2020
@IanMatthewHuff
Copy link
Member

Validated. Not sure how common it is. But I tried it about a half dozen times and didn't get the error. Great to not have the raw ipynb popping up any more as well.

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 11, 2020
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug ds-blocked labels Nov 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

5 participants