Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if interpreter file exists before displaying in a list #1352

Merged
merged 2 commits into from Apr 10, 2018

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Apr 9, 2018

Fixes #1305

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Apr 9, 2018

Codecov Report

Merging #1352 into master will increase coverage by 0.02%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
+ Coverage   71.16%   71.18%   +0.02%     
==========================================
  Files         269      269              
  Lines       12395    12401       +6     
  Branches     2198     2198              
==========================================
+ Hits         8821     8828       +7     
  Misses       3442     3442              
+ Partials      132      131       -1
Impacted Files Coverage Δ
...nterpreter/locators/services/currentPathService.ts 95.23% <91.66%> (+0.79%) ⬆️
src/client/linters/baseLinter.ts 87.5% <0%> (-1.05%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 52.96% <0%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd3103...fbc5018. Read the comment docs.

@DonJayamanne DonJayamanne changed the title WIP - Check if interpreter file exists before displaying in a list Check if interpreter file exists before displaying in a list Apr 9, 2018
@DonJayamanne DonJayamanne merged commit 058aa8d into microsoft:master Apr 10, 2018
@DonJayamanne DonJayamanne deleted the issue1305MSYS2 branch June 20, 2018 03:18
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spawn /usr/bin/python2 ENOENT when trying to select interpreter
2 participants