Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conda timeout to 60s as 30s is too low for some conda environments #18017

Closed
1 task done
DonJayamanne opened this issue Nov 12, 2021 · 1 comment
Closed
1 task done
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@DonJayamanne
Copy link

DonJayamanne commented Nov 12, 2021

VS Code version

1.62

Extension version

N/A

OS type

Windows

OS version

N/A

Python distribution

Anaconda

Python version

3.8

Language server

Default

Expected behaviour

Issue in Jupyter microsoft/vscode-jupyter#8119
I believe this is the same reason running conda info has a timeout of 50s instead of 30s or lower, See here

const result = await exec(command, ['info', '--json'], { timeout: 50000 });

Jim & Rong ran into issues and the problem was 30s was too low, increasing the timeout from 30s to 60s fixed it.

Actual behaviour

Conda envionments do not get activated, hence execution of python code against conda environments do not work.

Steps to reproduce

See details in Jupyter issue

Logs

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team labels Nov 12, 2021
@DonJayamanne DonJayamanne self-assigned this Nov 12, 2021
@karrtikr
Copy link

I believe this is the same reason running conda info has a timeout of 50s instead of 30s or lower, See here

Yes we updated the time to 50 seconds based on this stat: #17576

@karthiknadig karthiknadig removed the triage-needed Needs assignment to the proper sub-team label Nov 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants