Flake8 run every time when typing

[lifez]

Environment data

• VS Code version: 1.25.0
• Extension version (available under the Extensions sidebar): 2018.6.0
• OS and version: Osx 10.13.5
• Python version (& distribution if applicable, e.g. Anaconda): 3.6
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): pipenv

Actual behavior

• Flake8 always run when typing

Expected behavior

• Flake8 should run only when saving file

Steps to reproduce:

1. Typing on python code
2. Look at Language Server Example it always runs flake8 every time I typed text

Settings

This is my setting

{
  "editor.rulers": [
    80,
    120
  ],
  "jest.autoEnable": false,
  "editor.formatOnSave": false,
  "phpformatter.pharPath": "/usr/local/bin/php-cs-fixer.phar",
  "phpformatter.phpPath": "/usr/bin/php",
  "phpformatter.arguments": [
    "--level=psr2",
    "--fixers=linefeed,short_tag,indentation"
  ],
  "phpformatter.logging": true,
  "window.zoomLevel": 0,
  "editor.fontSize": 16,
  "editor.tabSize": 4,
  "vim.easymotion": true,
  "vim.sneak": true,
  "javascript.format.enable": false,
  "files.insertFinalNewline": true,
  "workbench.iconTheme": "seti",
  "files.trimTrailingWhitespace": true,
  "code-runner.executorMap": {
    "javascript": "node",
    "java": "cd $dir && javac $fileName && java $fileNameWithoutExt",
    "c": "cd $dir && gcc $fileName -o $fileNameWithoutExt && $dir$fileNameWithoutExt",
    "cpp": "cd $dir && g++ $fileName -o $fileNameWithoutExt && $dir$fileNameWithoutExt",
    "objective-c": "cd $dir && gcc -framework Cocoa $fileName -o $fileNameWithoutExt && $dir$fileNameWithoutExt",
    "php": "php",
    "python": "python3",
    "perl": "perl",
    "ruby": "ruby",
    "go": "go run",
    "lua": "lua",
    "groovy": "groovy",
    "powershell": "powershell -ExecutionPolicy ByPass -File",
    "bat": "cmd /c",
    "shellscript": "bash",
    "fsharp": "fsi",
    "csharp": "scriptcs",
    "vbscript": "cscript //Nologo",
    "typescript": "ts-node",
    "coffeescript": "coffee",
    "scala": "scala",
    "swift": "swift",
    "julia": "julia",
    "crystal": "crystal",
    "ocaml": "ocaml",
    "r": "Rscript",
    "applescript": "osascript",
    "clojure": "lein exec",
    "haxe": "haxe --cwd $dirWithoutTrailingSlash --run $fileNameWithoutExt",
    "rust": "cd $dir && rustc $fileName && $dir$fileNameWithoutExt",
    "racket": "racket",
    "ahk": "autohotkey",
    "autoit": "autoit3"
  },
  "git.enableSmartCommit": true,
  "guides.enabled": false,
  "files.exclude": {
    "**/.git": true,
    "**/.svn": true,
    "**/.hg": true,
    "**/CVS": true,
    "**/.DS_Store": true,
    "**/*.pyc": true,
    "**/venv/": true,
    "**/.env": true,
    "**/node_modules": true,
    "**/__pycache__": true,
    "USE_GITIGNORE": true
  },
  "search.exclude": {
    "**/.env": true
  },
  "editor.quickSuggestions": true,
  "editor.acceptSuggestionOnEnter": "on",
  "editor.quickSuggestionsDelay": 10,
  "editor.wordBasedSuggestions": true,
  "editor.parameterHints": true,
  "workbench.colorTheme": "An Old Hope Classic",
  "gitlens.advanced.messages": {
    "suppressCommitHasNoPreviousCommitWarning": false,
    "suppressCommitNotFoundWarning": false,
    "suppressFileNotUnderSourceControlWarning": true,
    "suppressGitVersionWarning": false,
    "suppressLineUncommittedWarning": false,
    "suppressNoRepositoryWarning": false,
    "suppressResultsExplorerNotice": false,
    "suppressShowKeyBindingsNotice": true,
    "suppressUpdateNotice": true,
    "suppressWelcomeNotice": false
  },
  "editor.minimap.enabled": false,
  "git.autofetch": true,
  "python.jediMemoryLimit": -1,
  "gitlens.keymap": "alternate",
  "workbench.statusBar.feedback.visible": false,
  "python.linting.ignorePatterns": [
    ".vscode/*.py",
    "**/site-packages/**/*.py",
    "/Users/phawin/.virtualenvs/**"
  ],
  "python.linting.flake8Enabled": true,
  "python.maxNumberOfProblems": 120,
  "eslint.autoFixOnSave": true,
  "gitlens.historyExplorer.enabled": true,
  "vim.easymotionMarkerFontSize": "16",
  "vim.easymotionMarkerHeight": 16,
  "python.jediEnabled": true,
  "python.linting.maxNumberOfProblems": 120,
  "python.linting.pylintEnabled": false,
  "python.unitTest.autoTestDiscoverOnSaveEnabled": false,
  "python.formatting.provider": "none"
}

[d3r3kk]

Thank you for the report. We will attempt to repro this on our side and prioritize it as necessary.

[brettcannon]

@lifez Can you also include your workspace settings.json (or your global one if the one you provided is your workspace one)? Basically we want to make sure you don't have files.autoSave turned on as that would explain what you're seeing.

[lifez]

@brettcannon This is my workspace settings.json

{
    "python.pythonPath": "/Users/phawin/.virtualenvs/service_survey-bTlPCBWn/bin/python",
    "python.unitTest.pyTestArgs": [
        "."
    ],
    "python.unitTest.unittestEnabled": false,
    "python.unitTest.nosetestsEnabled": false,
    "python.unitTest.pyTestEnabled": true,
    "python.linting.pylintEnabled": false
}

[lifez]

Uninstall Python Extension Pack and problem is gone.