Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically associate .flake8 files as an ini file #6506

Closed
thernstig opened this issue Jul 9, 2019 · 6 comments
Closed

Automatically associate .flake8 files as an ini file #6506

thernstig opened this issue Jul 9, 2019 · 6 comments
Labels
area-formatting feature-request Request for new features or functionality

Comments

@thernstig
Copy link

Currently I have to add this to my project so that .flake8 is considered an INI-file.

  "files.associations": {
    ".flake8": "ini"
  },

It would be cool if VS Code could add this into the extension instead so that one does not have to configure it.

@thernstig thernstig added triage-needed Needs assignment to the proper sub-team feature-request Request for new features or functionality labels Jul 9, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jul 9, 2019
@DonJayamanne DonJayamanne added triage-needed Needs assignment to the proper sub-team area-formatting and removed triage-needed Needs assignment to the proper sub-team labels Jul 9, 2019
@thernstig
Copy link
Author

Should be simple as per microsoft/vscode-eslint@4d8d146

@thernstig
Copy link
Author

@DonJayamanne I can fix this if you want me to, but the label "needs decision" makes me wonder if you want it fixed?

@DonJayamanne
Copy link

We're waiting to decide (team decision) whether we need such an enhancement.
If we get the green light I'll let you know here so you can create a PR.
My vite is to go with this change and add support for other similar files.

@luabud
Copy link
Member

luabud commented Sep 17, 2019

We changed the label to "needs PR", so if anyone wants to submit a PR for this we'll be happy to review it :)

@thernstig
Copy link
Author

@luabud @karthiknadig You can maybe close this now, I fixed it and it has been merged :)

See #7739

@luabud
Copy link
Member

luabud commented Nov 1, 2019

@thernstig thanks for reminding us to close this, and again, thanks for the PR! 😊

@luabud luabud closed this as completed Nov 1, 2019
@ghost ghost removed the needs PR label Nov 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-formatting feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants