Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stdin in jupyter messages #2664

Closed
rchiodo opened this issue Nov 15, 2019 · 4 comments
Closed

Support stdin in jupyter messages #2664

rchiodo opened this issue Nov 15, 2019 · 4 comments
Assignees

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Nov 15, 2019

I'm guessing 3 days to implement this.

I think all we need to do is change this code to allow_stdin:

    private generateRequest = (code: string, silent?: boolean): Kernel.IFuture | undefined => {
        //traceInfo(`Executing code in jupyter : ${code}`);
        try {
            const cellMatcher = new CellMatcher(this.configService.getSettings().datascience);
            return this.session ? this.session.requestExecute(
                {
                    // Remove the cell marker if we have one.
                    code: cellMatcher.stripFirstMarker(code),
                    stop_on_error: false,
                    allow_stdin: false,
                    store_history: !silent // Silent actually means don't output anything. Store_history is what affects execution_count
                },
                true
            ) : undefined;
        } catch (exc) {
            // Any errors generating a request should just be logged. User can't do anything about it.
            traceError(exc);
        }

        return undefined;
    }

Then provide UI to do the input.

@DonJayamanne
Copy link
Contributor

Isn't this the same as input for Jupyter messages?

@rchiodo
Copy link
Contributor Author

rchiodo commented Nov 15, 2019

Yes. Not sure what you're asking. There's two issues related to this. One is the epic, and one is the task.

@rchiodo
Copy link
Contributor Author

rchiodo commented Nov 15, 2019

This issue is the task

@rchiodo rchiodo self-assigned this Nov 15, 2019
@DonJayamanne
Copy link
Contributor

Validated

@lock lock bot locked as resolved and limited conversation to collaborators Nov 28, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants