Validate Mac Interpreters in the background #3909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3909 +/- ##
=======================================
- Coverage 79% 78% -<1%
=======================================
Files 408 409 +1
Lines 19049 19102 +53
Branches 3051 3057 +6
=======================================
+ Hits 14860 14897 +37
- Misses 4187 4203 +16
Partials 2 2
|
DonJayamanne
force-pushed
the
issue3908
branch
from
1e42598
to
c42c84c
Compare
karrtikr
reviewed
Jan 17, 2019
karrtikr
reviewed
Jan 17, 2019
karrtikr
approved these changes
Jan 17, 2019
karrtikr
reviewed
Jan 17, 2019
karrtikr
reviewed
Jan 17, 2019
| @@ -27,6 +28,12 @@ export class ApplicationDiagnostics implements IApplicationDiagnostics { | |||
| await diagnosticsService.handle(diagnostics); | |||
| } | |||
| })); | |||
|
|
|||
| // Validate the Mac interperter in the background. | |||
There was a problem hiding this comment.
@DonJayamanne Perhaps I'm being dense here, but you are already validating the Mac interpreter (not in the background) in the above lines 23 to 30.
In order to improve loading times of Python Extension, we should remove validating Mac interpreter in lines 23 to 30, and only validate it in the background.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3908
[n/a] Test plan is updated as appropriate[n/a]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)