Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Cmd-Shift-D behaviour #105

Closed
wants to merge 1 commit into from
Closed

Implement Cmd-Shift-D behaviour #105

wants to merge 1 commit into from

Conversation

andig
Copy link

@andig andig commented Jan 11, 2019

Partial fix for #100. Have not looked into multi-selection, please comment here what needs be changed.

@msftclas
Copy link

msftclas commented Jan 11, 2019

CLA assistant check
All CLA requirements met.

@andig
Copy link
Author

andig commented Jan 12, 2019

ping @auchenberg given the timeline of open PRs- is this something you would consider? Otherwise I'd need to bundle into its own plugin. Would be nice if you could let me know.

@andig
Copy link
Author

andig commented Jan 27, 2019

@auchenberg really disappointed that there's zero feedback :(.

Packaged into its own extension at https://marketplace.visualstudio.com/items?itemName=andig.sublime-cmd-shift-d.

@rebornix rebornix self-assigned this May 17, 2019
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andig, thanks for your help on this one ;) The code looks good to me in overall but it would be awesome if we have tests for the new command.

@andig
Copy link
Author

andig commented May 18, 2019

Could you point me to any meaningful test that I could base this on? The included tests only seem to apply to settings.

@andig
Copy link
Author

andig commented Oct 21, 2019

See microsoft/vscode#2075 for a built-in solution.

@andig andig closed this Oct 21, 2019
@andig andig deleted the cmd-shift-d branch October 21, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants