New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed regexp pattern, violated rule was missing #107

Merged
merged 1 commit into from Oct 3, 2016

Conversation

Projects
None yet
2 participants
@robstoll
Contributor

robstoll commented Oct 2, 2016

The current regexp pattern does not take the rule name into account which results in file names like the following (which of course cannot be opened by VS Code):
(no-shadowed-variable) src/...

fixed regexp pattern, violated rule was missing
The current regexp pattern does not take the rule name into account which results in file names like the following:
`(no-shadowed-variable) src/...`
@egamma

This comment has been minimized.

Show comment
Hide comment
@egamma

egamma Oct 3, 2016

Member

@robstoll thanks for catching this one 🌹

Member

egamma commented Oct 3, 2016

@robstoll thanks for catching this one 🌹

@egamma egamma merged commit 4564b34 into Microsoft:master Oct 3, 2016

@egamma egamma modified the milestone: October Nov 2, 2016

robstoll added a commit to robstoll/vscode-tslint that referenced this pull request Nov 27, 2016

reverts Microsoft#107, seems like rule name was removed
seems like the rule name is no longer emitted in a newer version of gulp-tslint

robstoll added a commit to robstoll/vscode-tslint that referenced this pull request Nov 27, 2016

reverts Microsoft#107, seems like rule name was removed
seems like the rule name is no longer emitted in a newer version of gulp-tslint

egamma added a commit that referenced this pull request Dec 4, 2016

Merge pull request #140 from robstoll/patch-2
reverts #107, seems like rule name was removed

AdenFlorian pushed a commit to AdenFlorian/vscode-tslint that referenced this pull request Oct 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment