Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

fixed regexp pattern, violated rule was missing #107

Merged
merged 1 commit into from
Oct 3, 2016

Conversation

robstoll
Copy link
Contributor

@robstoll robstoll commented Oct 2, 2016

The current regexp pattern does not take the rule name into account which results in file names like the following (which of course cannot be opened by VS Code):
(no-shadowed-variable) src/...

The current regexp pattern does not take the rule name into account which results in file names like the following:
`(no-shadowed-variable) src/...`
@egamma
Copy link
Member

egamma commented Oct 3, 2016

@robstoll thanks for catching this one 🌹

@egamma egamma merged commit 4564b34 into microsoft:master Oct 3, 2016
@egamma egamma modified the milestone: October Nov 2, 2016
robstoll added a commit to robstoll/vscode-tslint that referenced this pull request Nov 27, 2016
seems like the rule name is no longer emitted in a newer version of gulp-tslint
robstoll added a commit to robstoll/vscode-tslint that referenced this pull request Nov 27, 2016
seems like the rule name is no longer emitted in a newer version of gulp-tslint
egamma added a commit that referenced this pull request Dec 4, 2016
reverts #107, seems like rule name was removed
adenflorian pushed a commit to adenflorian/vscode-tslint that referenced this pull request Oct 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants