Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useYarn to ICreateVSIXOptions, IPublishOptions, and IPublishVSIXOptions #279

Merged
merged 1 commit into from Aug 10, 2018

Conversation

@aaomidi
Copy link

commented Aug 9, 2018

No description provided.

Amir Omidi

@joaomoreno joaomoreno self-assigned this Aug 10, 2018

@joaomoreno joaomoreno added this to the Backlog milestone Aug 10, 2018

@joaomoreno

This comment has been minimized.

Copy link
Member

commented Aug 10, 2018

Will look into this today.

@@ -25,6 +25,11 @@ export interface ICreateVSIXOptions {
* The base URL for images detected in Markdown files.
*/
baseImagesUrl?: string;

/**
* Should Yarn be used in place of NPM

This comment has been minimized.

Copy link
@joaomoreno

joaomoreno Aug 10, 2018

Member

Should be instead instead of in place.

@@ -52,6 +57,11 @@ export interface IPublishOptions {
* The base URL for images detected in Markdown files.
*/
baseImagesUrl?: string;

/**
* Should Yarn be used in place of NPM

This comment has been minimized.

Copy link
@joaomoreno

joaomoreno Aug 10, 2018

Member

Same as before.

/**
* Should Yarn be used in place of NPM
*/
useYarn?: boolean;

This comment has been minimized.

Copy link
@joaomoreno

joaomoreno Aug 10, 2018

Member

Indentation seems broken.

}

This comment has been minimized.

Copy link
@joaomoreno

joaomoreno Aug 10, 2018

Member

New line.

@joaomoreno joaomoreno merged commit 663c64e into microsoft:master Aug 10, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@joaomoreno joaomoreno modified the milestones: Backlog, July 2018, August 2018 Aug 10, 2018

@joaomoreno

This comment has been minimized.

Copy link
Member

commented Aug 10, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.