Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add useYarn to ICreateVSIXOptions, IPublishOptions, and IPublishVSIXOptions #279

Merged
merged 1 commit into from Aug 10, 2018
Merged

Add useYarn to ICreateVSIXOptions, IPublishOptions, and IPublishVSIXOptions #279

merged 1 commit into from Aug 10, 2018

Conversation

aaomidi
Copy link

@aaomidi aaomidi commented Aug 9, 2018

No description provided.

@aaomidi aaomidi mentioned this pull request Aug 9, 2018
Closed
@joaomoreno joaomoreno self-assigned this Aug 10, 2018
@joaomoreno joaomoreno added this to the Backlog milestone Aug 10, 2018
@joaomoreno
Copy link
Member

Will look into this today.

joaomoreno
joaomoreno reviewed Aug 10, 2018
View reviewed changes
src/api.ts
@@ -25,6 +25,11 @@ export interface ICreateVSIXOptions {
* The base URL for images detected in Markdown files.
*/
baseImagesUrl?: string;

/**
* Should Yarn be used in place of NPM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be instead instead of in place.

joaomoreno
joaomoreno reviewed Aug 10, 2018
View reviewed changes
src/api.ts
@@ -52,6 +57,11 @@ export interface IPublishOptions {
* The base URL for images detected in Markdown files.
*/
baseImagesUrl?: string;

/**
* Should Yarn be used in place of NPM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before.

joaomoreno
joaomoreno reviewed Aug 10, 2018
View reviewed changes
src/api.ts
/**
* Should Yarn be used in place of NPM
*/
useYarn?: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation seems broken.

@joaomoreno joaomoreno mentioned this pull request Aug 10, 2018
Closed
joaomoreno
joaomoreno reviewed Aug 10, 2018
View reviewed changes
src/api.ts
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line.

@joaomoreno joaomoreno merged commit 663c64e into microsoft:master Aug 10, 2018
@joaomoreno joaomoreno modified the milestones: Backlog, July 2018, August 2018 Aug 10, 2018
@joaomoreno
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaomoreno joaomoreno joaomoreno left review comments

Assignees

@joaomoreno joaomoreno

Labels
None yet
Projects
None yet
Milestone
August 2018
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaomidi @joaomoreno