New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM package lacks shortcut in PATH #11431

Closed
joaomoreno opened this Issue Sep 2, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@joaomoreno
Member

joaomoreno commented Sep 2, 2016

Just installed the Insiders RPM package in CentOS and code-insiders wasn't placed on the $PATH:

➜  ~ sudo find / -name 'code-insiders'
find: ‘/run/user/1000/gvfs’: Permission denied
/usr/share/code-insiders
/usr/share/code-insiders/bin/code-insiders
/usr/share/code-insiders/code-insiders
➜  ~ which code-insiders
/usr/bin/which: no code-insiders in (/home/joao/.nvm/versions/node/v5.10.1/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/bin:/sbin:/home/joao/bin)

@dbaeumer dbaeumer added this to the August 2016 milestone Sep 2, 2016

@dbaeumer

This comment has been minimized.

Show comment
Hide comment
@dbaeumer

dbaeumer Sep 2, 2016

Member

Looks like a regression

Member

dbaeumer commented Sep 2, 2016

Looks like a regression

@Tyriar

This comment has been minimized.

Show comment
Hide comment
@Tyriar

Tyriar Sep 2, 2016

Member

There is meant to be a symlink in /usr/bin, created here https://github.com/Microsoft/vscode/blob/master/resources/linux/rpm/code.spec.template#L33

@joaomoreno can you do a ls /usr/bin | grep code? I'll try repro when I get to the office

Member

Tyriar commented Sep 2, 2016

There is meant to be a symlink in /usr/bin, created here https://github.com/Microsoft/vscode/blob/master/resources/linux/rpm/code.spec.template#L33

@joaomoreno can you do a ls /usr/bin | grep code? I'll try repro when I get to the office

@Tyriar

This comment has been minimized.

Show comment
Hide comment
@Tyriar

Tyriar Sep 2, 2016

Member

I managed to repro this when installing via the UI package manager but not when installing via the command line. Note that installing via the command line (yum) requires sudo

Member

Tyriar commented Sep 2, 2016

I managed to repro this when installing via the UI package manager but not when installing via the command line. Note that installing via the command line (yum) requires sudo

@Tyriar

This comment has been minimized.

Show comment
Hide comment
@Tyriar

Tyriar Sep 2, 2016

Member

Taking it off August since this is not a regression, at least not in the past month.

Member

Tyriar commented Sep 2, 2016

Taking it off August since this is not a regression, at least not in the past month.

@Tyriar

This comment has been minimized.

Show comment
Hide comment
@Tyriar

Tyriar Oct 23, 2016

Member

To verifier, please verify using Fedora:

  • Install rpm using software center
  • Ensure code/code-insiders command shows up in the terminal
  • Uninstall package
  • Ensure code/code-insiders command is not available in terminal
  • Install via command line (see docs)
  • Ensure code/code-insiders command shows up in the terminal
Member

Tyriar commented Oct 23, 2016

To verifier, please verify using Fedora:

  • Install rpm using software center
  • Ensure code/code-insiders command shows up in the terminal
  • Uninstall package
  • Ensure code/code-insiders command is not available in terminal
  • Install via command line (see docs)
  • Ensure code/code-insiders command shows up in the terminal

@Tyriar Tyriar added the linux label Oct 23, 2016

@chrmarti chrmarti added the verified label Oct 27, 2016

sverrirs added a commit to sverrirs/vscode that referenced this issue Oct 29, 2016

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.