Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist user choice in Find options (case, whole word, regex) in the Find widget in editor #11574

Closed
peterbourgon opened this issue Sep 6, 2016 · 10 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations feature-request Request for new features or functionality
Milestone

Comments

@peterbourgon
Copy link

peterbourgon commented Sep 6, 2016

  • VSCode Version: 1.4.0
  • OS Version: Mac OS El Capitan 10.11.4

Steps to Reproduce:

  1. Open VS Code and some file
  2. Cmd+F to find something
  3. Check the box to enable case-sensitivity and regex searching
  4. Close VS Code
  5. Open VS Code and some file again
  6. Cmd+F to find something

Expected behavior: the boxes for case-sensitivity and regex searching are checked.

Actual behavior: the boxes for case-sensitivity and regex searching are unchecked.

I always want to search with these options enabled. How can I persist this state across restarts?

@ramya-rao-a ramya-rao-a added the search Search widget and operation issues label Sep 6, 2016
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Sep 6, 2016

@jrieken The Find options are persisted for text search across files after restarting VS Code but not for text search in a file

@jrieken jrieken assigned alexdima and unassigned jrieken Sep 7, 2016
@alexdima
Copy link
Member

alexdima commented Sep 7, 2016

Let's track in #10344 we should add a configuration option where you could specify the default toggle states.

@alexdima alexdima closed this as completed Sep 7, 2016
@alexdima alexdima added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 7, 2016
@ramya-rao-a
Copy link
Contributor

I'd prefer we persisted user choice (notepad++, sublime and Visual Studio do persist user choice) rather than set configuration option explicitly. This way text search inside a file and across files would be consistent too.

@alexdima
Copy link
Member

alexdima commented Sep 8, 2016

@ramya-rao-a I haven't noticed Visual Studio persisting the user choice. Same as we, they have a find widget for each editor (so if you open multiple editors side-by-side they each get their find widget). What would we persist if we have multiple find widgets that have different toggles?

@peterbourgon
Copy link
Author

@alexandrudima Last writer wins? Honestly that's an edge condition, any decision is fine.

@alexdima
Copy link
Member

alexdima commented Sep 8, 2016

That works for me. I will do the following:

  • anytime a find widget toggle is changed, I will persist it (last one wins)
  • when the workbench starts up, I will read the persisted values and start with those by default.

@alexdima alexdima reopened this Sep 8, 2016
@alexdima alexdima added feature-request Request for new features or functionality editor-find Editor find operations and removed search Search widget and operation issues labels Sep 8, 2016
@alexdima alexdima added this to the September 2016 milestone Sep 8, 2016
@alexdima alexdima removed the *duplicate Issue identified as a duplicate of another issue(s) label Sep 8, 2016
@ramya-rao-a ramya-rao-a changed the title Find > Regex mode needs to be re-enabled every time I open the program Persist user choice in Find options (case, whole word, regex) in the Find widget in editor Sep 8, 2016
@alexdima alexdima modified the milestones: October 2016, September 2016 Sep 27, 2016
@alexdima alexdima modified the milestones: November 2016, October 2016 Oct 27, 2016
@rwatts3
Copy link

rwatts3 commented Nov 18, 2016

Any updates on this matter ?

@alexdima alexdima modified the milestones: Backlog, November 2016 Dec 8, 2016
@ryanwinchester
Copy link

ryanwinchester commented Mar 19, 2017

Trying out vscode after hearing much hype lately, and this is my biggest issue in adopting it.

I use (cmd+d) multiple cursors a lot, and having to do cmd+f and toggling case-sensitive every time I open an editor is a pain in the rear-end.

Even if I could use cmd+alt+c (my hotkey for alfred snippets) it would still be annoying.

@peterbourgon
Copy link
Author

Still annoyed by this on a daily basis as well :)

@rebornix rebornix self-assigned this Apr 28, 2017
@rebornix
Copy link
Member

rebornix commented May 6, 2017

Let's track the setting persistence in #6158

@rebornix rebornix closed this as completed May 6, 2017
@rebornix rebornix added the *duplicate Issue identified as a duplicate of another issue(s) label May 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

7 participants