New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to bring up multiple dialogs on same dirty file when closing #11928

Closed
mohsen1 opened this Issue Sep 13, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@mohsen1

mohsen1 commented Sep 13, 2016

  • VSCode Version: 1.5.2
  • OS Version: OS X

Steps to Reproduce:

  1. Open a few files
  2. Make a file dirty
  3. Open a few more files
  4. Hit Cmd+W multiple time very quickly
  5. When tabs close one by one and it reaches to the file that was dirty, it prompts you to save that file, choose the cancel option

VSCode will show you the save dialog again and again. Apparently it cached the close command to that file.

@bpasero bpasero self-assigned this Sep 13, 2016

@bpasero bpasero added the bug label Sep 13, 2016

@bpasero bpasero added this to the September 2016 milestone Sep 13, 2016

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Sep 13, 2016

Member

Good catch 👍

Member

bpasero commented Sep 13, 2016

Good catch 👍

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero May 4, 2017

Member

Bottom line of this problem is that when a dialog (such as the confirm dialog when closing a dirty editor) opens, for some reason it is still possible to execute commands via keyboard on macOS. These just pile up and execute after the dialog is dismissed. I have not found a solution that would not be a hack. If someone has ideas how to tackle this, jump on it.

Member

bpasero commented May 4, 2017

Bottom line of this problem is that when a dialog (such as the confirm dialog when closing a dirty editor) opens, for some reason it is still possible to execute commands via keyboard on macOS. These just pile up and execute after the dialog is dismissed. I have not found a solution that would not be a hack. If someone has ideas how to tackle this, jump on it.

@DHainzl

This comment has been minimized.

Show comment
Hide comment
@DHainzl

DHainzl Aug 11, 2017

Additionally, it seems that not only keyboard events, but also mouse events are piling up (in my concrete case, middle mouse click on a tab).

DHainzl commented Aug 11, 2017

Additionally, it seems that not only keyboard events, but also mouse events are piling up (in my concrete case, middle mouse click on a tab).

@bpasero bpasero closed this in 590a611 Nov 16, 2017

@roblourens roblourens added the verified label Dec 6, 2017

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 31, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.