Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to bring up multiple dialogs on same dirty file when closing #11928

Closed
mohsen1 opened this issue Sep 13, 2016 · 3 comments
Closed

Possible to bring up multiple dialogs on same dirty file when closing #11928

mohsen1 opened this issue Sep 13, 2016 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Milestone

Comments

@mohsen1
Copy link

mohsen1 commented Sep 13, 2016

  • VSCode Version: 1.5.2
  • OS Version: OS X

Steps to Reproduce:

  1. Open a few files
  2. Make a file dirty
  3. Open a few more files
  4. Hit Cmd+W multiple time very quickly
  5. When tabs close one by one and it reaches to the file that was dirty, it prompts you to save that file, choose the cancel option

VSCode will show you the save dialog again and again. Apparently it cached the close command to that file.

@bpasero bpasero self-assigned this Sep 13, 2016
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Sep 13, 2016
@bpasero bpasero added this to the September 2016 milestone Sep 13, 2016
@bpasero
Copy link
Member

bpasero commented Sep 13, 2016

Good catch 👍

@bpasero bpasero changed the title When closing multiple tabs with Cmd+W when a file is dirty prompts save dialog multiple times Possible to bring up multiple dialogs on same dirty file when closing Sep 14, 2016
@bpasero bpasero modified the milestones: Backlog, September 2016 Sep 14, 2016
@bpasero bpasero added the help wanted Issues identified as good community contribution opportunities label Oct 31, 2016
@bpasero bpasero added workbench file-explorer Explorer widget issues and removed workbench help wanted Issues identified as good community contribution opportunities labels Apr 7, 2017
@bpasero bpasero added the help wanted Issues identified as good community contribution opportunities label May 4, 2017
@bpasero
Copy link
Member

bpasero commented May 4, 2017

Bottom line of this problem is that when a dialog (such as the confirm dialog when closing a dirty editor) opens, for some reason it is still possible to execute commands via keyboard on macOS. These just pile up and execute after the dialog is dismissed. I have not found a solution that would not be a hack. If someone has ideas how to tackle this, jump on it.

@DHainzl
Copy link

DHainzl commented Aug 11, 2017

Additionally, it seems that not only keyboard events, but also mouse events are piling up (in my concrete case, middle mouse click on a tab).

@bpasero bpasero added workbench-editors Managing of editor widgets in workbench window and removed file-explorer Explorer widget issues help wanted Issues identified as good community contribution opportunities labels Nov 15, 2017
@bpasero bpasero modified the milestones: Backlog, November 2017 Nov 15, 2017
@roblourens roblourens added the verified Verification succeeded label Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Development

No branches or pull requests

4 participants