Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'KeyboardEvent.keyIdentifier' is deprecated and will be removed in M54 #11953

Closed
bpasero opened this issue Sep 13, 2016 · 4 comments
Closed

'KeyboardEvent.keyIdentifier' is deprecated and will be removed in M54 #11953

bpasero opened this issue Sep 13, 2016 · 4 comments
Assignees
@alexdima
Labels
important Issue identified as high-priority keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues
Milestone
March 2017

Comments

@bpasero
Copy link
Member

bpasero commented Sep 13, 2016 •
edited

Running with Chrome 52 I see this in the console. 'KeyboardEvent.keyIdentifier' is deprecated and will be removed in M54, around September 2016. See https://www.chromestatus.com/features/5316065118650368 for more details.

Seems to be used in nativeKeymap.ts
@jrieken jrieken removed their assignment Sep 13, 2016
@bpasero bpasero changed the title 'KeyboardEvent.keyIdentifier' is deprecated and will be removed in M53 'KeyboardEvent.keyIdentifier' is deprecated and will be removed in M54 Nov 10, 2016
@bpasero
Copy link
Member Author

bpasero commented Nov 10, 2016

Looks like it will be removed in M54, not 53

@alexdima alexdima added important Issue identified as high-priority keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues labels Mar 2, 2017
@alexdima alexdima added this to the Backlog milestone Mar 2, 2017
@alexdima
Copy link
Member

alexdima commented Mar 2, 2017

@bpasero Please let me know when/if this blocks updating.

@bpasero
Copy link
Member Author

bpasero commented Mar 2, 2017

@alexandrudima it blocks us as soon as we update to a newer electron version. latest electron bundles Chrome 56.

@bpasero
Copy link
Member Author

bpasero commented Mar 2, 2017 •
edited

@alexandrudima fyi I created a build with latest Electron 1.6.2 for Windows here: https://az764295.vo.msecnd.net/insider/d42d4467e681308a5f82b61cb11ee6b91f1b9864/VSCode-win32-1.11.0-insider.zip

@alexdima alexdima modified the milestones: March 2017, Backlog Mar 6, 2017
@pixieaka pixieaka mentioned this issue Mar 17, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
important Issue identified as high-priority keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
3 participants
@bpasero @jrieken @alexdima