Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[themes] Dark theme uses much more colors than light theme for both JS and TS #1270

Closed
isidorn opened this issue Dec 14, 2015 · 5 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues verification-found Issue verification failed verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Dec 14, 2015

Compare the two screenshots. We use much more colors in the dark theme. This is not consistent since those two are the default themes and they should be symetric imho. Both for Typescript and Javascript
@stevencl @bgashler1 opinions welcome

screen shot 2015-12-14 at 14 57 28

screen shot 2015-12-14 at 14 58 04

@isidorn isidorn changed the title Dark theme uses much more colors than light theme for typescript Dark theme uses much more colors than light theme for both JS and TS Dec 14, 2015
@stevencl
Copy link
Member

Agreed, this should be consistent (in terms of what gets coloured that is, not in terms of the specific colours). What is the reason for the param name or function name not being coloured in the light theme? Do we just not have good colours specified for the light theme? If so, could @bgashler1 suggest something?

@dbaeumer dbaeumer modified the milestone: Backlog Dec 14, 2015
@bgashler1
Copy link
Contributor

I agree this is a problem with consistency, and it needs to be addressed. I'll try out some colors that can make up for the missing ones in the light theme.

@aeschli aeschli modified the milestones: Dec 2015, Backlog Dec 16, 2015
@aeschli aeschli added bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues labels Dec 16, 2015
@aeschli
Copy link
Contributor

aeschli commented Dec 16, 2015

fix delivered, I removed the yellow and turquise. The goal is to stay as close as possible to the original Visual Studio light and dark themes. For users that like more colors we have custom themes even from extensions.

@aeschli aeschli closed this as completed Dec 16, 2015
@aeschli aeschli changed the title Dark theme uses much more colors than light theme for both JS and TS [themes] Dark theme uses much more colors than light theme for both JS and TS Dec 16, 2015
@aeschli aeschli assigned isidorn and unassigned aeschli Dec 16, 2015
@isidorn
Copy link
Contributor Author

isidorn commented Dec 16, 2015

But turquise we still use in light theme. Maybe bring back turquise, since now interface names are colored in dark theme but not in light -> inconsistent

@isidorn isidorn reopened this Dec 16, 2015
@isidorn isidorn added the verification-found Issue verification failed label Dec 16, 2015
@isidorn isidorn assigned aeschli and unassigned isidorn Dec 16, 2015
@aeschli
Copy link
Contributor

aeschli commented Dec 16, 2015

I removed turquise from the light theme as well. We are now consistent to what we had in 0.9.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues verification-found Issue verification failed verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants