New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[themes] Dark theme uses much more colors than light theme for both JS and TS #1270

Closed
isidorn opened this Issue Dec 14, 2015 · 5 comments

Comments

Projects
None yet
5 participants
@isidorn
Contributor

isidorn commented Dec 14, 2015

Compare the two screenshots. We use much more colors in the dark theme. This is not consistent since those two are the default themes and they should be symetric imho. Both for Typescript and Javascript
@stevencl @bgashler1 opinions welcome

screen shot 2015-12-14 at 14 57 28

screen shot 2015-12-14 at 14 58 04

@isidorn isidorn changed the title from Dark theme uses much more colors than light theme for typescript to Dark theme uses much more colors than light theme for both JS and TS Dec 14, 2015

@stevencl

This comment has been minimized.

Show comment
Hide comment
@stevencl

stevencl Dec 14, 2015

Member

Agreed, this should be consistent (in terms of what gets coloured that is, not in terms of the specific colours). What is the reason for the param name or function name not being coloured in the light theme? Do we just not have good colours specified for the light theme? If so, could @bgashler1 suggest something?

Member

stevencl commented Dec 14, 2015

Agreed, this should be consistent (in terms of what gets coloured that is, not in terms of the specific colours). What is the reason for the param name or function name not being coloured in the light theme? Do we just not have good colours specified for the light theme? If so, could @bgashler1 suggest something?

@dbaeumer dbaeumer modified the milestone: Backlog Dec 14, 2015

@bgashler1

This comment has been minimized.

Show comment
Hide comment
@bgashler1

bgashler1 Dec 15, 2015

Contributor

I agree this is a problem with consistency, and it needs to be addressed. I'll try out some colors that can make up for the missing ones in the light theme.

Contributor

bgashler1 commented Dec 15, 2015

I agree this is a problem with consistency, and it needs to be addressed. I'll try out some colors that can make up for the missing ones in the light theme.

@aeschli

This comment has been minimized.

Show comment
Hide comment
@aeschli

aeschli Dec 16, 2015

Contributor

fix delivered, I removed the yellow and turquise. The goal is to stay as close as possible to the original Visual Studio light and dark themes. For users that like more colors we have custom themes even from extensions.

Contributor

aeschli commented Dec 16, 2015

fix delivered, I removed the yellow and turquise. The goal is to stay as close as possible to the original Visual Studio light and dark themes. For users that like more colors we have custom themes even from extensions.

@aeschli aeschli closed this Dec 16, 2015

@aeschli aeschli changed the title from Dark theme uses much more colors than light theme for both JS and TS to [themes] Dark theme uses much more colors than light theme for both JS and TS Dec 16, 2015

@aeschli aeschli assigned isidorn and unassigned aeschli Dec 16, 2015

@isidorn

This comment has been minimized.

Show comment
Hide comment
@isidorn

isidorn Dec 16, 2015

Contributor

But turquise we still use in light theme. Maybe bring back turquise, since now interface names are colored in dark theme but not in light -> inconsistent

Contributor

isidorn commented Dec 16, 2015

But turquise we still use in light theme. Maybe bring back turquise, since now interface names are colored in dark theme but not in light -> inconsistent

@isidorn isidorn reopened this Dec 16, 2015

@isidorn isidorn assigned aeschli and unassigned isidorn Dec 16, 2015

aeschli added a commit that referenced this issue Dec 16, 2015

@aeschli

This comment has been minimized.

Show comment
Hide comment
@aeschli

aeschli Dec 16, 2015

Contributor

I removed turquise from the light theme as well. We are now consistent to what we had in 0.9.0.

Contributor

aeschli commented Dec 16, 2015

I removed turquise from the light theme as well. We are now consistent to what we had in 0.9.0.

@aeschli aeschli closed this Dec 16, 2015

aeschli added a commit that referenced this issue Dec 16, 2015

aeschli added a commit that referenced this issue Dec 16, 2015

@aeschli aeschli assigned isidorn and unassigned aeschli Dec 16, 2015

@isidorn isidorn added the verified label Dec 17, 2015

@aeschli aeschli referenced this issue Jan 25, 2016

Closed

Test more colorful default theme #2256

1 of 1 task complete

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.